Skip to content

Input mixer mute mode #666

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 29, 2025
Merged

Input mixer mute mode #666

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e1141ac
Input mixer mute mode
hiroshihorie Apr 10, 2025
b2a118e
lib 125.6422.29
hiroshihorie Apr 10, 2025
ca8fcdb
Merge branch 'main' into hiroshi/mute-mode-3
hiroshihorie Apr 23, 2025
b73aaf3
nanpa
hiroshihorie Apr 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .nanpa/new-mic-mute-mode.kdl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
patch type="added" "New mic mute mode"
2 changes: 1 addition & 1 deletion LiveKitClient.podspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ Pod::Spec.new do |spec|

spec.source_files = "Sources/**/*"

spec.dependency("LiveKitWebRTC", "= 125.6422.28")
spec.dependency("LiveKitWebRTC", "= 125.6422.29")
spec.dependency("SwiftProtobuf")
spec.dependency("Logging", "= 1.5.4")
spec.dependency("DequeModule", "= 1.1.4")
Expand Down
2 changes: 1 addition & 1 deletion Package.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ let package = Package(
],
dependencies: [
// LK-Prefixed Dynamic WebRTC XCFramework
.package(url: "https://github.com/livekit/webrtc-xcframework.git", exact: "125.6422.28"),
.package(url: "https://github.com/livekit/webrtc-xcframework.git", exact: "125.6422.29"),
.package(url: "https://github.com/apple/swift-protobuf.git", from: "1.26.0"),
.package(url: "https://github.com/apple/swift-log.git", from: "1.5.4"),
.package(url: "https://github.com/apple/swift-collections.git", from: "1.1.0"),
Expand Down
2 changes: 1 addition & 1 deletion [email protected]
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ let package = Package(
],
dependencies: [
// LK-Prefixed Dynamic WebRTC XCFramework
.package(url: "https://github.com/livekit/webrtc-xcframework.git", exact: "125.6422.28"),
.package(url: "https://github.com/livekit/webrtc-xcframework.git", exact: "125.6422.29"),
.package(url: "https://github.com/apple/swift-protobuf.git", from: "1.29.0"),
.package(url: "https://github.com/apple/swift-log.git", from: "1.6.2"), // 1.6.x requires Swift >=5.8
.package(url: "https://github.com/apple/swift-collections.git", from: "1.1.0"),
Expand Down
2 changes: 1 addition & 1 deletion [email protected]
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ let package = Package(
],
dependencies: [
// LK-Prefixed Dynamic WebRTC XCFramework
.package(url: "https://github.com/livekit/webrtc-xcframework.git", exact: "125.6422.28"),
.package(url: "https://github.com/livekit/webrtc-xcframework.git", exact: "125.6422.29"),
.package(url: "https://github.com/apple/swift-protobuf.git", from: "1.29.0"),
.package(url: "https://github.com/apple/swift-log.git", from: "1.6.2"), // 1.6.x requires Swift >=5.8
.package(url: "https://github.com/apple/swift-collections.git", from: "1.1.0"),
Expand Down
5 changes: 5 additions & 0 deletions Sources/LiveKit/Audio/Manager/AudioManager+MuteMode.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,9 @@ public enum MicrophoneMuteMode {
/// Restarts the internal `AVAudioEngine` without mic input when muted.
/// This is slower, and muted speaker detection does not work. No sound effect is played.
case restart
/// Simply mutes the output of the input mixer.
/// The mic indicator remains on, and the internal `AVAudioEngine` continues running without reconfiguration.
case inputMixer
case unknown
}

Expand Down Expand Up @@ -73,6 +76,7 @@ extension RTCAudioEngineMuteMode {
switch self {
case .voiceProcessing: return .voiceProcessing
case .restartEngine: return .restart
case .inputMixer: return .inputMixer
case .unknown: return .unknown
@unknown default: return .unknown
}
Expand All @@ -85,6 +89,7 @@ extension MicrophoneMuteMode {
case .unknown: return .unknown
case .voiceProcessing: return .voiceProcessing
case .restart: return .restartEngine
case .inputMixer: return .inputMixer
}
}
}