Skip to content

Input mixer mute mode #666

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 29, 2025
Merged

Input mixer mute mode #666

merged 4 commits into from
Apr 29, 2025

Conversation

hiroshihorie
Copy link
Member

@hiroshihorie hiroshihorie commented Apr 10, 2025

Adds new mic mute mode: inputMixer, which simply sets inputMixer's outputVolume to 0.0 .
This mute's the mic without reconfiguring input / audio session etc. Mic indicator will remain on.

Patch: webrtc-sdk/webrtc@21ee7f0

Copy link

ilo-nanpa bot commented Apr 10, 2025

it seems like you haven't added any nanpa changeset files to this PR.

if this pull request includes changes to code, make sure to add a changeset, by writing a file to .nanpa/<unique-name>.kdl:

minor type="added" "Introduce frobnication algorithm"

refer to the manpage for more information.

@hiroshihorie hiroshihorie marked this pull request as ready for review April 10, 2025 16:05
@hiroshihorie hiroshihorie requested review from ladvoc and pblazej April 11, 2025 13:39
@pblazej
Copy link
Contributor

pblazej commented Apr 15, 2025

Any real-world test cases here?

@hiroshihorie
Copy link
Member Author

Not sure if there's an easy way to test this one but I added it to examples app :
https://github.com/livekit-examples/swift-example/pull/71/files

Copy link
Contributor

@pblazej pblazej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All 3 modes seem to work 👍

@hiroshihorie hiroshihorie merged commit ece078a into main Apr 29, 2025
4 checks passed
@hiroshihorie hiroshihorie deleted the hiroshi/mute-mode-3 branch April 29, 2025 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants