make compose tunnel agent tunnel private #141
Conversation
was returning a positive response (accept) before closing the ClientForward, which caused duplicate key errors when changing a tunnel access
separate hooks for env creation and filtering URLs
royra
force-pushed
the
private-compose-tunnel-agent-service
branch
4 times, most recently
from
b5060d6
to
fc3f335
Compare
royra
force-pushed
the
private-compose-tunnel-agent-service
branch
from
fc3f335
to
47d4f6e
Compare
| retryOpts = { retries: 0 }, | ||
| tunnelUrlsForService, | ||
| credentials, | ||
| includeAccessCredentials, |
There was a problem hiding this comment.
Basically, the credentials and includeAccessCredentials are external to queryTunnels to remove dependencies and give more flexibility to the calling client. (in this case, the calling can't separate the credentials from the urls)
There was a problem hiding this comment.
Maybe it can be spitted to two methods, and used in the command (injectCredentials(queryTunnels))
There was a problem hiding this comment.
Basically, the credentials and includeAccessCredentials are external to queryTunnels to remove dependencies and give more flexibility to the calling client. (in this case, the calling can't separate the credentials from the urls)
credentials are now needed to query the tunnels (because the compose tunnel agent is private)
extracting includeAccessCredentials is still possible but not worth it IMO.
also contains:
projectNameout ofqueryTunnelsso theurlscommand would not need a compose file