Allow to use the id param without compose when running preevy urls command #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
royra
reviewed
Jul 19, 2023
| const projectName = (await this.ensureUserModel()).name | ||
| log.debug(`project: ${projectName}`) | ||
| const envId = flags.id || await findAmbientEnvId(projectName) | ||
| const [envId, projectName] = flags.id ? [flags.id, flags.id] : await (async () => { |
There was a problem hiding this comment.
giving the id as the projectName is confusing.
it's working because projectName is actually not needed by tunnelUrlsForEnv and commands.url. should probably refactor that out.
There was a problem hiding this comment.
So, I should remove project param from:
preevy/packages/core/src/tunneling/index.ts
Line 107 in 5d59c2a
|
a fix for this is in #141 |
|
fixed by #141 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In similar fashion to down and to some degree, docker compose, allow users to get the URLs of the environments without the need to specify the compose files or project name.
Currently, the resolver already uses the envId in this flow:
So, the behavior should be consistent