-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new mintDrop function and useMintDrop hook #175
Conversation
🦋 Changeset detectedLatest commit: a5f1e92 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One general feedback on this PR, a mint is a drop event, the goal is to create an asset similar to the mint and lazymint so it feels weird to have it as part of the exchange. I do understand the idea because we can optionally have to pay for the mint but the asset is not created yet thus this is not really an exchange in my opinion.
I would have put this in the asset.mintFromDrop
with only the dropId
as the chain
and collection
can be found from the drop
One question on this one, |
Yes you can fetch the drop to get the info we are doing that in some places where we fetch an offer to get the asset |
…-js into feature/mint-drop
Co-authored-by: Anthony <[email protected]>
…-js into feature/mint-drop
Have a look one last time Anthony. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Except for one part, the rest looks good, I couldn't really test so please let me know when I can test properly and/or how to test properly
Required for https://trello.com/c/FFkLOSNr/947-growth-hacking-drops
Hook added from https://github.com/liteflow-labs/o-mee/blob/main/hooks/useMintDrop.ts
If namings are good, might need to add to the documentation as well.