Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

False positive when minting from a drop #179

Open
antho1404 opened this issue Sep 22, 2023 · 0 comments
Open

False positive when minting from a drop #179

antho1404 opened this issue Sep 22, 2023 · 0 comments

Comments

@antho1404
Copy link
Member

This should actually "work" but would be a false positive with the following flow:

  • User mints 1 token
    • The current ownership is 0
    • The asset is synced with the API
    • The new ownership is 1
    • The polling has a change between 0 and 1, so all is good
  • User mints 1 more token
    • The current ownership is 1
    • The polling from 0 to 1 stops because it is different <-- This is the false positive
    • The asset is synced with the API
    • The new ownership is 2

Because of that, we would exit the function too early and might have issues with redirecting to the asset page, and the asset is not yet synced with the API, which will result in a 404

Originally posted by @antho1404 in #175 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant