Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: 更新滚动条样式,适配动画 #233

Merged
merged 1 commit into from
Aug 1, 2024
Merged

chore: 更新滚动条样式,适配动画 #233

merged 1 commit into from
Aug 1, 2024

Conversation

Whale107
Copy link
Contributor

  1. 更新滚动条样式,适配动画
  2. 修复进度条圆角问题以及当进度为1时进度滑块未在进度槽中的问题

Log:

deepin-ci-robot added a commit to linuxdeepin/qt6integration that referenced this pull request Jul 19, 2024
@deepin-ci-robot
sync: from linuxdeepin/qt5integration
5067ab2 
Synchronize source files from linuxdeepin/qt5integration.

Source-pull-request: linuxdeepin/qt5integration#233
@deepin-ci-robot deepin-ci-robot mentioned this pull request Jul 19, 2024
Closed
@Whale107 Whale107 changed the title chore: 更新滚动条样式,适配动画 更新滚动条样式,适配动画 chore: 更新滚动条样式,适配动画 Jul 19, 2024
deepin-ci-robot added a commit to linuxdeepin/qt6integration that referenced this pull request Jul 23, 2024
@deepin-ci-robot
sync: from linuxdeepin/qt5integration
aa537f9 
Synchronize source files from linuxdeepin/qt5integration.

Source-pull-request: linuxdeepin/qt5integration#233
deepin-ci-robot added a commit to linuxdeepin/qt6integration that referenced this pull request Jul 23, 2024
@deepin-ci-robot
sync: from linuxdeepin/qt5integration
affd7d1 
Synchronize source files from linuxdeepin/qt5integration.

Source-pull-request: linuxdeepin/qt5integration#233
deepin-ci-robot added a commit to linuxdeepin/qt6integration that referenced this pull request Jul 23, 2024
@deepin-ci-robot
sync: from linuxdeepin/qt5integration
b3b7e5c 
Synchronize source files from linuxdeepin/qt5integration.

Source-pull-request: linuxdeepin/qt5integration#233
deepin-ci-robot added a commit to linuxdeepin/qt6integration that referenced this pull request Jul 23, 2024
@deepin-ci-robot
sync: from linuxdeepin/qt5integration
8a297c5 
Synchronize source files from linuxdeepin/qt5integration.

Source-pull-request: linuxdeepin/qt5integration#233
deepin-ci-robot added a commit to linuxdeepin/qt6integration that referenced this pull request Jul 31, 2024
@deepin-ci-robot
sync: from linuxdeepin/qt5integration
e2aab26 
Synchronize source files from linuxdeepin/qt5integration.

Source-pull-request: linuxdeepin/qt5integration#233
deepin-ci-robot added a commit to linuxdeepin/qt6integration that referenced this pull request Aug 1, 2024
@deepin-ci-robot
sync: from linuxdeepin/qt5integration
4346134 
Synchronize source files from linuxdeepin/qt5integration.

Source-pull-request: linuxdeepin/qt5integration#233
@Whale107 Whale107 requested review from zccrs and kegechen and removed request for zccrs August 1, 2024 03:28
zccrs
zccrs requested changes Aug 1, 2024
View reviewed changes
styleplugins/chameleon/chameleonstyle.cpp Outdated Show resolved Hide resolved
styleplugins/chameleon/chameleonstyle.h Outdated Show resolved Hide resolved
styleplugins/chameleon/chameleonstyle.cpp Show resolved Hide resolved
deepin-ci-robot added a commit to linuxdeepin/qt6integration that referenced this pull request Aug 1, 2024
@deepin-ci-robot
sync: from linuxdeepin/qt5integration
a470a53 
Synchronize source files from linuxdeepin/qt5integration.

Source-pull-request: linuxdeepin/qt5integration#233
deepin-ci-robot added a commit to linuxdeepin/qt6integration that referenced this pull request Aug 1, 2024
@deepin-ci-robot
sync: from linuxdeepin/qt5integration
e224753 
Synchronize source files from linuxdeepin/qt5integration.

Source-pull-request: linuxdeepin/qt5integration#233
zccrs
zccrs requested changes Aug 1, 2024
View reviewed changes
styleplugins/chameleon/chameleonstyle.h Outdated Show resolved Hide resolved
deepin-ci-robot added a commit to linuxdeepin/qt6integration that referenced this pull request Aug 1, 2024
@deepin-ci-robot
sync: from linuxdeepin/qt5integration
dd02db3 
Synchronize source files from linuxdeepin/qt5integration.

Source-pull-request: linuxdeepin/qt5integration#233
zccrs
zccrs reviewed Aug 1, 2024
View reviewed changes
Copy link
Member

@zccrs zccrs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

另外考虑下垂直方向的进度条

styleplugins/chameleon/chameleonstyle.cpp Outdated Show resolved Hide resolved
styleplugins/chameleon/chameleonstyle.cpp Outdated Show resolved Hide resolved
deepin-ci-robot added a commit to linuxdeepin/qt6integration that referenced this pull request Aug 1, 2024
@deepin-ci-robot
sync: from linuxdeepin/qt5integration
afa06c8 
Synchronize source files from linuxdeepin/qt5integration.

Source-pull-request: linuxdeepin/qt5integration#233
@Whale107
chore: 更新滚动条样式,适配动画
71550f5 
更新滚动条样式,适配动画

Log:
deepin-ci-robot added a commit to linuxdeepin/qt6integration that referenced this pull request Aug 1, 2024
@deepin-ci-robot
sync: from linuxdeepin/qt5integration
ca38250 
Synchronize source files from linuxdeepin/qt5integration.

Source-pull-request: linuxdeepin/qt5integration#233
@deepin-ci-robot
Copy link
Contributor

deepin pr auto review

关键摘要:

  • 在ChameleonMovementAnimation::setCurrentRect函数中，应该检查rect是否与m_currentRect不同，以避免不必要的重复设置。
  • ChameleonMovementAnimation::setCurrentRect函数中的m_currentRect变量应该设置为只读，以防止在动画过程中被修改。
  • 在ChameleonStyle::drawControl函数中，使用QPainterPath进行剪切操作可能会导致性能问题，建议使用更高效的方法。
  • 在ChameleonStyle::drawControl函数中，使用QTimer::singleShot进行动画间隔设置，建议使用更灵活的动画控制方式。
  • 在ChameleonStyle::drawControl函数中，创建ChameleonMovementAnimation实例时没有设置动画目标矩形，可能导致动画无法正确启动。
  • 在ChameleonStyle::drawControl函数中，使用dynamic_cast进行类型转换，建议使用更安全的类型检查方法。

是否建议立即修改:
是

@deepin-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Whale107, zccrs

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Whale107 Whale107 merged commit 7858504 into linuxdeepin:dev/animation Aug 1, 2024
17 of 20 checks passed
Whale107 added a commit to Whale107/qt5integration that referenced this pull request Sep 23, 2024
@Whale107
chore: 更新滚动条样式,适配动画 (linuxdeepin#233)
03f34b5 
更新滚动条样式,适配动画

Log:
Whale107 added a commit that referenced this pull request Sep 23, 2024
@Whale107 @zccrs @FeiWang1119
merge dev/animation to master (#243)
3fd431f 
* feat: add animation for menu's selected backgroud

Add a ChameleonAnimation class for the geometry translate animation.

* chore: 更新滚动条样式,适配动画 (#233)

更新滚动条样式,适配动画

Log:

* chore: add round and remove shadow for menu item

add round and remove shadow for menu item

Log:

* chore: 更改checkbox和radio实现方式为dci图标,增加动效 (#236)

更改checkbox和radio实现方式为dci图标,增加动效

Log:

* fix: adjust progressbar color (#237)

adjust progressbar color

Log:

* fix: 修复在选中框之外hover 和点击也有动画的问题 (#238)

checkbox和radio有框选区和文字区,应该只对框选区事件做处理

Log:

---------

Co-authored-by: JiDe Zhang <[email protected]>
Co-authored-by: wangfei <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zccrs zccrs zccrs approved these changes

@kegechen kegechen Awaiting requested review from kegechen

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Whale107 @deepin-ci-robot @zccrs