Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sync: from linuxdeepin/qt5integration #41

Closed
wants to merge 1 commit into from

Conversation

deepin-ci-robot
Copy link
Contributor

Synchronize source files from linuxdeepin/qt5integration.

Source-pull-request: linuxdeepin/qt5integration#233

@deepin-ci-robot
Copy link
Contributor Author

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: deepin-ci-robot

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@deepin-ci-robot deepin-ci-robot force-pushed the sync-pr-233-nosync branch 4 times, most recently from b3b7e5c to 8a297c5 Compare July 23, 2024 08:04
@deepin-ci-robot deepin-ci-robot force-pushed the sync-pr-233-nosync branch 6 times, most recently from dd02db3 to afa06c8 Compare August 1, 2024 12:16
Synchronize source files from linuxdeepin/qt5integration.

Source-pull-request: linuxdeepin/qt5integration#233
@deepin-ci-robot
Copy link
Contributor Author

deepin pr auto review

关键摘要:

  • ChameleonMovementAnimation类中,setTargetRect方法可能会导致动画开始时直接跳到目标矩形,而不是平滑过渡。
  • drawMenuItemBackground方法中,使用QTimer::singleShot来延迟启动动画可能不是最佳选择,因为可能会导致用户体验不佳。
  • drawMenuItemBackground方法中,动画的启动和停止逻辑可以进一步简化,避免使用QTimerisHorizontal变量。
  • drawMenuItem方法中,对animation的检查应该在animation->isRuning()之前进行,以避免潜在的空指针异常。
  • drawMenuItem方法中,使用painter->setOpacity(1.0 - animation->progress())进行透明度过渡效果可能不正确,因为animation->progress()返回的是一个比例值,而不是一个实际的透明度值。

是否建议立即修改:

@deepin-bot
Copy link
Contributor

deepin-bot bot commented Aug 21, 2024

TAG Bot

New tag: 6.0.19
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #47

@deepin-bot
Copy link
Contributor

deepin-bot bot commented Oct 31, 2024

TAG Bot

New tag: 6.0.21
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #53

@deepin-bot
Copy link
Contributor

deepin-bot bot commented Nov 15, 2024

TAG Bot

New tag: 6.0.22
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #55

@deepin-bot
Copy link
Contributor

deepin-bot bot commented Nov 22, 2024

TAG Bot

New tag: 6.0.23
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #57

@kegechen kegechen closed this Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants