Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update control and update version #2549

Merged
merged 1 commit into from
Jan 10, 2025

Conversation

lzwind
Copy link
Contributor

@lzwind lzwind commented Jan 10, 2025

update control and update version

Log: update control and update version

update control and update version

Log: update control and update version
@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: lzwind

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@deepin-ci-robot
Copy link

deepin pr auto review

代码审查意见

debian/changelog 文件

  • 提交信息格式:提交信息应该简洁明了,并且包含必要的更改描述。当前提交信息中只提到了更新版本号,没有具体说明更新的内容。建议添加更详细的更新说明,以便于其他开发者理解更改的背景和目的。

debian/control 文件

  • 依赖版本更新:在 debian/control 文件中,将 libdfm-io-dev, libdfm-mount-dev, libdfm-burn-dev 更新为 libdfm6-io-dev, libdfm6-mount-dev, libdfm6-burn-dev。这个更改可能是为了匹配新的库版本。但是,需要确认这些库版本是否已经发布,并且是否与 dde-file-manager 的版本兼容。如果这些库版本尚未发布,或者不兼容,那么这个更改可能会导致构建失败。

改进建议

  • 更新提交信息:在 debian/changelog 文件中,添加更详细的更新说明,以便于其他开发者理解更改的背景和目的。
  • 依赖版本确认:在 debian/control 文件中,确认 libdfm6-io-dev, libdfm6-mount-dev, libdfm6-burn-dev 的版本已经发布,并且与 dde-file-manager 的版本兼容。如果这些库版本尚未发布,或者不兼容,需要与相关团队沟通,确保更改是正确的。

代码质量

  • 代码注释:建议在 debian/changelogdebian/control 文件中添加适当的注释,解释为什么进行这些更改,以及这些更改对项目的影响。

代码性能

  • 无性能相关更改:当前提交中没有涉及到性能相关的更改,因此不需要进行性能审查。

代码安全

  • 无安全相关更改:当前提交中没有涉及到安全相关的更改,因此不需要进行安全审查。

Copy link

  • 检测到debian目录文件有变更: debian/control

Copy link

  • 敏感词检查失败, 检测到1个文件存在敏感词
详情
{
    "debian/control": [
        {
            "line": "Homepage: http://www.deepin.org",
            "line_number": 71,
            "rule": "S35",
            "reason": "Url link | 6fe814dfb7"
        }
    ]
}

Copy link

TAG Bot

TAG: 6.5.25
EXISTED: no
DISTRIBUTION: unstable

@lzwind
Copy link
Contributor Author

lzwind commented Jan 10, 2025

/forcemerge

@deepin-bot
Copy link
Contributor

deepin-bot bot commented Jan 10, 2025

This pr force merged! (status: blocked)

@deepin-bot deepin-bot bot merged commit 99c652a into linuxdeepin:master Jan 10, 2025
18 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants