Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add new type for file sort #2543

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

feat: add new type for file sort #2543

wants to merge 3 commits into from
+1,028 −928

Conversation

Lighto-Ku
Copy link
Contributor

1.Add new type of column in list view mode.
2.Add new type for file sort.

Log: add new type for file sort
Task: https://pms.uniontech.com/story-view-37825.html

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Lighto-Ku

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Lighto-Ku Lighto-Ku force-pushed the fix-master branch 2 times, most recently from c1ba2b2 to 7f13a07 Compare January 9, 2025 03:23
@deepin-ci-robot
Copy link

deepin pr auto review

代码审查意见：

  1. 在dfmplugin_propertydialog_global.h文件中，移除了kFileImageSizeFiled和kFileImageSize的定义，但未在basicwidget.cpp、basicwidget.h、filebaseinfoview.cpp等文件中删除相应的代码，可能会导致编译错误或运行时错误。建议检查并删除所有相关的代码。

  2. 在basicwidget.cpp文件中，fileImgSize变量被删除，但imageExtenInfo函数中仍然使用了fileImgSize，这可能会导致编译错误。建议更新imageExtenInfo函数，使其使用fileMediaResolution代替fileImgSize。

  3. 在canvasbasesortmenuscene.cpp、canvasmenu_defines.h、canvasmenuscene.cpp、extendcanvasscene.cpp等文件中，新增了kSrtTimeCreated和kSrtTimeCreated的定义和实现，但未在相应的菜单项中添加对应的排序逻辑。建议添加相应的排序逻辑，以便用户可以根据文件创建时间进行排序。

  4. 在filebaseinfoview.cpp文件中，将fileViewSize的标签从"Dimension"更改为"Resolution"，这可能会影响用户界面的可读性。建议确认这一更改是否符合用户需求。

  5. 在sortbybutton.cpp文件中，新增了根据文件创建时间进行排序的功能，但未在SortByButtonPrivate::setItemSortRoles函数中添加对应的排序角色。建议添加相应的排序角色，以便用户可以根据文件创建时间进行排序。

  6. 在fileitemdata.cpp文件中，新增了根据文件创建时间获取数据的功能，但未在FileItemData::data函数中添加对应的角色。建议添加相应的角色，以便用户可以获取文件创建时间。

  7. 在fileviewmodel.cpp文件中，新增了根据文件创建时间获取角色显示字符串的功能，但未在FileViewModel::roleDisplayString函数中添加对应的角色。建议添加相应的角色，以便用户可以显示文件创建时间。

  8. 在filesortworker.cpp文件中，新增了根据文件创建时间进行排序的功能，但未在FileSortWorker::lessThan函数中添加对应的排序逻辑。建议添加相应的排序逻辑，以便用户可以根据文件创建时间进行排序。

  9. 在fileview.cpp文件中，新增了初始化默认表头视图的功能，但未在FileView::initDefaultHeaderView函数中添加对应的逻辑。建议添加相应的逻辑，以便用户可以初始化默认表头视图。

  10. 在fileview.h文件中，新增了初始化默认表头视图的函数声明，但未在FileView类中添加对应的实现。建议添加相应的实现，以便用户可以初始化默认表头视图。

  11. 在fileview_p.cpp文件中，新增了初始化列表模式视图的功能，但未在FileViewPrivate::initListModeView函数中添加对应的逻辑。建议添加相应的逻辑，以便用户可以初始化列表模式视图。

以上是本次代码提交的审查意见，希望能够对您有所帮助。

@deepin-bot
Copy link
Contributor

deepin-bot bot commented Jan 9, 2025

TAG Bot

New tag: 6.5.23
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #2544

@deepin-bot
Copy link
Contributor

deepin-bot bot commented Jan 10, 2025

TAG Bot

New tag: 6.5.24
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #2547

@deepin-bot
Copy link
Contributor

deepin-bot bot commented Jan 10, 2025

TAG Bot

New tag: 6.5.25
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #2549

@Lighto-Ku
feat: add new type for file sort
17c0afb 
1.Add new type of column in list view mode.
2.Add new type for file sort.

Log: add new type for file sort
Task: https://pms.uniontech.com/story-view-37825.html
@Lighto-Ku
refactor: unify image size and resolution fields
5ef0eb1 
This commit simplifies and unifies how image dimensions are displayed in the
property dialog and file details view:

- Remove redundant kFileImageSize field and merge with kFileMediaResolution
- Rename "Dimension" to "Resolution" for consistency
- Simplify time-related labels:
  - "Time created" -> "Created"
  - "Time accessed" -> "Accessed"
  - "Time modified" -> "Modified"
- Update enum values and field mappings accordingly

This change reduces code duplication and provides a more consistent user
experience when displaying image properties.

Log: unify image size and resolution fields
@Lighto-Ku
chore: update translation
9b70fc9 
as title

Log: update translation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Lighto-Ku @deepin-ci-robot