Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PoC: x230-fhd_edp (on top of efifb next steps) [coreboot 4.22+) #1524

Closed
wants to merge 9 commits into from

Commits on Nov 8, 2023

  1. FB_EFI next step: remove CONFIG_BOOT_KERNEL_ADD=intel_iommu=on intel_…

    …iommu=igfx_off, add CONFIG_BOOT_KERNEL_REMOVE=intel_iommu=on intel_iommu=igfx_off, remove quiet removal from CONFIG_BOOT_KERNEL_REMOVE. TLDR: do not interfere with OS setting its own boot policies
    
    Signed-off-by: Thierry Laurion <[email protected]>
    tlaurion committed Nov 8, 2023
    Configuration menu
    Copy the full SHA
    ce0751b View commit details
    Browse the repository at this point in the history
  2. FB_EFI next step: remove coreboot's Heads linux intel_iommu statement…

    …s. TODO: check linux config to see if enabling automatically works as expected.
    
    Signed-off-by: Thierry Laurion <[email protected]>
    tlaurion committed Nov 8, 2023
    Configuration menu
    Copy the full SHA
    183d41f View commit details
    Browse the repository at this point in the history
  3. FB_EFI next step: make sure CONFIG_INTEL_IOMMU_DEFAULT_ON=y is on on …

    …all intel boards touched in past commit
    
    Touches c216, x230-flash, x230-legacy and x230-maximized.
    TODO: Other boards, including AMD ones (qemu/kgpe) have this ON, including nv41/ns50 (which uses i915drm which most probably causes problems)
     Note that qemu boards use q35 in config, but were made to have both i440fx and q35, where q35 is tested, which explains why its on by default there.
    
    Signed-off-by: Thierry Laurion <[email protected]>
    tlaurion committed Nov 8, 2023
    Configuration menu
    Copy the full SHA
    9683961 View commit details
    Browse the repository at this point in the history
  4. kgpe-d16 linux configs: remove Intel related stuff, enable AMD relate…

    …d IOMMU settings
    
    Signed-off-by: Thierry Laurion <[email protected]>
    tlaurion committed Nov 8, 2023
    Configuration menu
    Copy the full SHA
    194ba8b View commit details
    Browse the repository at this point in the history

Commits on Nov 9, 2023

  1. Adapt NV41/NS50 changes, unify bootsplash file usage for branding

    Taken from : https://github.com/Nitrokey/heads/tree/temp-release-v2.3
    
    - Move branding/Heads/bootsplash-1024x768.jpg -> branding/Heads/bootsplash.jpg (We don't care about the size. Make filename generic)
    - Adapt all coreboot configs so bootsplash is adapted by BRAND_NAME CONFIG_BOOTSPLASH_FILE="@BRAND_DIR@/bootsplash.jpg"
      - Reminders :
        - Makefile changes Heads to defined BRAND_NAME in board config
        - Makefile changes -e 's!@BRAND_DIR@!$(pwd)/branding/$(BRAND_NAME)!g'
    - nv41/nv50
      - coreboot oldefconfigs adapted by:
        - make BOARD=nitropad-ns50 coreboot.modify_and_save_oldconfig_in_place
        - make BOARD=nitropad-nv41 coreboot.modify_and_save_oldconfig_in_place
      - linux oldefconfigs adapted by
        - make BOARD=nitropad-nv41 linux.modify_and_save_oldconfig_in_place
          - since this is shared config across nv41/ns50: it only needs to be done for a single board
    
    Signed-off-by: Thierry Laurion <[email protected]>
    tlaurion committed Nov 9, 2023
    Configuration menu
    Copy the full SHA
    3a648df View commit details
    Browse the repository at this point in the history
  2. coreboot configs: unify linux console output to 'quiet loglevel=2' bu…

    …t for qemu/flash boards
    
    Signed-off-by: Thierry Laurion <[email protected]>
    tlaurion committed Nov 9, 2023
    Configuration menu
    Copy the full SHA
    5f0e69c View commit details
    Browse the repository at this point in the history
  3. linux config: oldconfig for all, make sure BRAND_NAME is there to be …

    …overriden
    
    TODO: linuxboot still not touched...
    Signed-off-by: Thierry Laurion <[email protected]>
    tlaurion committed Nov 9, 2023
    Configuration menu
    Copy the full SHA
    e8f0b94 View commit details
    Browse the repository at this point in the history

Commits on Nov 10, 2023

  1. x230-legacy-flash board: fixup pointing to x230 as opposed to t430. F…

    …ix coreboot config path to bootsplash
    
    Signed-off-by: Thierry Laurion <[email protected]>
    tlaurion committed Nov 10, 2023
    Configuration menu
    Copy the full SHA
    d110a64 View commit details
    Browse the repository at this point in the history
  2. PoC: pre coreboot 4.22 with fhd mod in, test compilation of x230-maxi…

    …mized and x230-maximized-fhd_edp for regression test on x230 and single user test
    
    patches/coreboot-pre422-x230fhd/7a42712.patch created per git fetch https://review.coreboot.org/coreboot refs/changes/50/28950/23 && git format-patch -1 --stdout FETCH_HEAD > ~/heads/patches/coreboot-pre422-x230fhd/7a42712.patch on top of coreboot commit 42f1fef5a620e98e7ece6a60744992265cc409d7 as specified under x230fhd coreboot fork defined under modules/coreboot
    
    Signed-off-by: Thierry Laurion <[email protected]>
    tlaurion committed Nov 10, 2023
    Configuration menu
    Copy the full SHA
    428c33a View commit details
    Browse the repository at this point in the history