PoC: x230-fhd_edp (on top of efifb next steps) [coreboot 4.22+) #1524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…iommu=igfx_off, add CONFIG_BOOT_KERNEL_REMOVE=intel_iommu=on intel_iommu=igfx_off, remove quiet removal from CONFIG_BOOT_KERNEL_REMOVE. TLDR: do not interfere with OS setting its own boot policies Signed-off-by: Thierry Laurion <[email protected]>
…s. TODO: check linux config to see if enabling automatically works as expected. Signed-off-by: Thierry Laurion <[email protected]>
…all intel boards touched in past commit Touches c216, x230-flash, x230-legacy and x230-maximized. TODO: Other boards, including AMD ones (qemu/kgpe) have this ON, including nv41/ns50 (which uses i915drm which most probably causes problems) Note that qemu boards use q35 in config, but were made to have both i440fx and q35, where q35 is tested, which explains why its on by default there. Signed-off-by: Thierry Laurion <[email protected]>
…d IOMMU settings Signed-off-by: Thierry Laurion <[email protected]>
Taken from : https://github.com/Nitrokey/heads/tree/temp-release-v2.3 - Move branding/Heads/bootsplash-1024x768.jpg -> branding/Heads/bootsplash.jpg (We don't care about the size. Make filename generic) - Adapt all coreboot configs so bootsplash is adapted by BRAND_NAME CONFIG_BOOTSPLASH_FILE="@BRAND_DIR@/bootsplash.jpg" - Reminders : - Makefile changes Heads to defined BRAND_NAME in board config - Makefile changes -e 's!@BRAND_DIR@!$(pwd)/branding/$(BRAND_NAME)!g' - nv41/nv50 - coreboot oldefconfigs adapted by: - make BOARD=nitropad-ns50 coreboot.modify_and_save_oldconfig_in_place - make BOARD=nitropad-nv41 coreboot.modify_and_save_oldconfig_in_place - linux oldefconfigs adapted by - make BOARD=nitropad-nv41 linux.modify_and_save_oldconfig_in_place - since this is shared config across nv41/ns50: it only needs to be done for a single board Signed-off-by: Thierry Laurion <[email protected]>
…t for qemu/flash boards Signed-off-by: Thierry Laurion <[email protected]>
…overriden TODO: linuxboot still not touched... Signed-off-by: Thierry Laurion <[email protected]>
…ix coreboot config path to bootsplash Signed-off-by: Thierry Laurion <[email protected]>
|
Builds happening for x230-maximized and x230-maximized-fhd_edp (non-hotp) below under checks. |
…mized and x230-maximized-fhd_edp for regression test on x230 and single user test patches/coreboot-pre422-x230fhd/7a42712.patch created per git fetch https://review.coreboot.org/coreboot refs/changes/50/28950/23 && git format-patch -1 --stdout FETCH_HEAD > ~/heads/patches/coreboot-pre422-x230fhd/7a42712.patch on top of coreboot commit 42f1fef5a620e98e7ece6a60744992265cc409d7 as specified under x230fhd coreboot fork defined under modules/coreboot Signed-off-by: Thierry Laurion <[email protected]>
|
misnamed x230-maximized for x230-hotp-maximized under circleci, which created caches that were invalid.... |
|
I just don't mind testing both :) |
|
Not forgot, but doesn't build. Patches are being worked on upstream which when I receive signal will update PR to point to proper fixed pre 4.22 commit and fhd patch to have user reports of x230 fhd so that hopefully is part of 4.22 this time. |
tlaurion
changed the title
20 tasks
|
Superseeded by #1604 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DO NOT FLASH yet. This is build test and regression test for x230 and x230-fhd (non-hotp) for #1523.
There is an observable tendency of everybody forking coreboot... But I still prefer pointing to releases with pending patches in files then forking and maintaining patches in fork, in the goalof tracking files related to patches on top of chosen releases in the goal of seeing those patches merged upstream...) as currently defined under modules/coreboot (since 4.22 is not yet released and I would love to see fhd/edp merged upstream) and have Heads users test fhd on top of ~4.22 so that it has a chance of being under 4.22...
So here we have:
git fetch https://review.coreboot.org/coreboot refs/changes/50/28950/23 && git format-patch -1 --stdout FETCH_HEAD > ~/heads/patches/coreboot-x230fhd-x230fhd/7a42712.patchon top of coreboot commit 42f1fef5a620e98e7ece6a60744992265cc409d7make BOARD=x230-maximized coreboot.save_in_oldconfig_format_in_placemake BOARD=x230-maximized-fhd_edp coreboot.save_in_oldconfig_format_in_placeOnly last commit is relevant here (atop of #1522 fixes)