WiP: Heads logo, heads inside Plexus bootsplash, bootsplash used by default #1451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…efault Attempt to address linuxboot#1402 (comment)
tlaurion
added a commit
to tlaurion/heads
that referenced
this pull request
Oct 2, 2023
- Move logos and bootsplashes from blobs to branding/Heads/ - Makefile: add support for BRAND_DIR which depends on BRAND_NAME which defaults to Heads if undefined - Boards coreboot configs: change bootsplash directory to depend on BRAND_DIR - branding/Heads/bootsplash-1024x768.jpg points to branding/Heads/d-wid-ThePlexus_coreboot-linuxboot-heads_background-plain_DonateQrCode.jpg Notes to d-wid: - @d-wid: the xcf has to go. We cannot add 4mb of binary data in repo that might get deleted in the future - I propose this naming scheme so that credit are clear directly in filenames, where commit shoud say that bing is original author as previously stated under linuxboot#1451 - I'm not sure what online dev environement can do and cannot in terms of commit modifications. You seems to have been able to squash all prior commits. What is missing now would be properly credit Bing, ThrillerAtPlay and ThePlexus in your commit for the releative filenames and that would be good to go. - I would then recreate a PR based on your PR, add Makefile magic and modify all coreboot configs to be aligned with qemu config as under this commit
|
Replaced by #1506 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And..... this is why i'm not a graphic designer :)
Someone wants to play with the xcf files and turn this into amazingness?
Steal it, do another PR, have fun!
Attempt to address #1402 (comment)