Improve CI

[waywardmonkeys]

No description provided.

[Philipp-M]

Apart from the one comment LGTM. Thanks.

[waywardmonkeys]

I've got other things I want to add to this ... but having it as a draft lets it get early review (like now) as well as make sure the pieces work as they get written.

[Philipp-M]

Yeah I get this, but I think generally it's better/easier (to review) to just have small "atomic" changes if possible in PRs (sometimes it's not, or it's overhead for everyone involved...), so I would suggest splitting changes in separate PRs

[richard-uk1]

Thanks for working on this - it would be good if we could find a way for the CI to catch problems like #82 , which I think should be possible. Once things are a bit more settled I'd like to write some tests.

[Philipp-M]

it would be good if we could find a way for the CI to catch problems like #82

I doubt that this is possible without a few tests, as it's a runtime error.

Setting up good E2E tests would probably be the best for finding such issues (using something like playwright) but this requires quite some work I think.

[waywardmonkeys]

Let's say this is ready for review now and further work on improving CI can happen.

This can't be merged at the moment as it will fail until another PR is landed to fix a formatting issue recently introduced.

[Philipp-M]

Have you tried what I've commented? (Don't have to, I will open a follow-up PR otherwise and check, if that's working)

[waywardmonkeys]

I did not yet. That's part of why I haven't just gone and merged this. :)

[Philipp-M]

Well my addition hasn't regressed this, but it hasn't helped that much either^^ Seems like clippy and rustfmt is default anyway...

But it probably doesn't matter much, it shouldn't really add much time on CI

[waywardmonkeys]

Ah, you're right. They are both included in the minimal profile. Ah well. Maybe I'll revisit it once we can enable clippy checks...