Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

svg: clippy: Fix useless format warnings. #79

Merged
merged 1 commit into from
Jul 8, 2023

Conversation

waywardmonkeys
Copy link
Contributor

Since to_svg returns a String, we don't need to format it to a string.

Since `to_svg` returns a `String`, we don't need to format it
to a string.
@waywardmonkeys
Copy link
Contributor Author

(The current CI isn't actually testing this... but it will once we're able to land PR #78 and possible follow-ups.)

Copy link
Contributor

@Philipp-M Philipp-M left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! (I'll take the liberty to merge this, as it's an obvious improvement)

@Philipp-M Philipp-M merged commit df1742e into linebender:main Jul 8, 2023
1 check passed
@waywardmonkeys waywardmonkeys deleted the xilemsvg-clippy branch July 8, 2023 12:14
waywardmonkeys added a commit to waywardmonkeys/xilem that referenced this pull request Jul 8, 2023
I broke this in PR linebender#79.
@waywardmonkeys waywardmonkeys mentioned this pull request Jul 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants