Run the smoke tests on macOS arm runners #448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Philipp-M
approved these changes
Feb 19, 2024
waywardmonkeys
approved these changes
Feb 20, 2024
simbleau
pushed a commit
that referenced
this pull request
Feb 20, 2024
* Run the smoke tests on macOS arm runners * Also remove the outdated comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://developer.apple.com/documentation/paravirtualizedgraphics?language=objc might work here
This would be running actual Metal on actual GPUs, which is exciting
https://docs.github.com/en/actions/using-github-hosted-runners/about-github-hosted-runners/about-github-hosted-runners#standard-github-hosted-runners-for-public-repositories - these are included runners, as far as I can see.
I don't know whether we can accidentally use a chargeable runner - I hope not, but I'm not sure how to confirm that
I've also removed an outdated comment, as it's no longer useful