Use safe create_surface api
#446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I thought to double check that that
But somewhere in all the simplifications, that no longer seems to be a problem. So I've gotten rid of that |
ratmice
force-pushed
the
safe_create_surface
branch
from
8741955 to
fdc9a98
Compare
simbleau
pushed a commit
that referenced
this pull request
Feb 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is an attempt at using the safe surface creation API, I only tested that it runs on wayland and compiles on wasm,
but I've never been able to run on WebGPU here (even without the patch), so I can't test that or other platforms.
Feel it is worth marking as draft because I haven't tested other platforms.