Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[limactl copy] change make logs quiet by default and adds a verbose flag to enable verbose log output #2998

Merged
merged 1 commit into from
Dec 25, 2024
Merged

[limactl copy] change make logs quiet by default and adds a verbose flag to enable verbose log output #2998

merged 1 commit into from
Dec 25, 2024
+15 −1

Conversation

olamilekan000
Copy link
Contributor

@olamilekan000 olamilekan000 commented Dec 10, 2024 •
edited
Loading 

Change makes log output quiet by default and adds a "--verbose" flag for 
detailed logging in the Copy action function.

Link to issue - #2963 (comment)

@olamilekan000 olamilekan000 force-pushed the add-quiet-flag-to-command branch from 2721762 to 04b3bdc Compare December 10, 2024 00:10
AkihiroSuda
AkihiroSuda previously approved these changes Dec 10, 2024
View reviewed changes
Copy link
Member

@AkihiroSuda AkihiroSuda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@AkihiroSuda AkihiroSuda added this to the v1.0.3 milestone Dec 10, 2024
@AkihiroSuda AkihiroSuda added the area/cli limactl CLI user experience label Dec 10, 2024
@olamilekan000
Copy link
Contributor Author

Thanks

You're welcome!

nirs
nirs reviewed Dec 10, 2024
View reviewed changes
cmd/limactl/copy.go Outdated Show resolved Hide resolved
alexandear
alexandear reviewed Dec 10, 2024
View reviewed changes
cmd/limactl/copy.go Outdated Show resolved Hide resolved
@olamilekan000 olamilekan000 force-pushed the add-quiet-flag-to-command branch 2 times, most recently from c97e496 to 036c68a Compare December 10, 2024 21:35
jandubois
jandubois reviewed Dec 10, 2024
View reviewed changes
cmd/limactl/copy.go Outdated Show resolved Hide resolved
@olamilekan000 olamilekan000 force-pushed the add-quiet-flag-to-command branch from 7c46686 to bfcdfa6 Compare December 23, 2024 23:04
@olamilekan000 olamilekan000 changed the title feat: add --quiet flag to suppress verbose logs in feat: add --quiet flag to suppress verbose logs in Copy sub-command Dec 23, 2024
@olamilekan000 olamilekan000 force-pushed the add-quiet-flag-to-command branch 4 times, most recently from ce643ab to 8aeda06 Compare December 23, 2024 23:41
AkihiroSuda
AkihiroSuda reviewed Dec 24, 2024
View reviewed changes
.gitignore Outdated Show resolved Hide resolved
@olamilekan000 olamilekan000 force-pushed the add-quiet-flag-to-command branch 2 times, most recently from de9a845 to 64978bc Compare December 24, 2024 11:18
@AkihiroSuda AkihiroSuda changed the title feat: add --quiet flag to suppress verbose logs in Copy sub-command [limactl copy] change make logs quiet by default and adds a verbose flag to enable verbose log output Dec 24, 2024
@olamilekan000 olamilekan000 force-pushed the add-quiet-flag-to-command branch from 64978bc to 5cf98de Compare December 24, 2024 16:35
@olamilekan000 olamilekan000 force-pushed the add-quiet-flag-to-command branch from 5cf98de to deb9406 Compare December 24, 2024 16:45
@olamilekan000 olamilekan000 force-pushed the add-quiet-flag-to-command branch 3 times, most recently from 7aa9463 to dd19570 Compare December 24, 2024 16:52
AkihiroSuda
AkihiroSuda reviewed Dec 25, 2024
View reviewed changes
cmd/limactl/copy.go Outdated Show resolved Hide resolved
AkihiroSuda
AkihiroSuda reviewed Dec 25, 2024
View reviewed changes
cmd/limactl/copy.go Outdated Show resolved Hide resolved
AkihiroSuda
AkihiroSuda reviewed Dec 25, 2024
View reviewed changes
cmd/limactl/copy.go Outdated Show resolved Hide resolved
@olamilekan000 olamilekan000 force-pushed the add-quiet-flag-to-command branch from dd19570 to 900d2a9 Compare December 25, 2024 09:45
AkihiroSuda
AkihiroSuda approved these changes Dec 25, 2024
View reviewed changes
Copy link
Member

@AkihiroSuda AkihiroSuda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@AkihiroSuda AkihiroSuda merged commit f0d3814 into lima-vm:master Dec 25, 2024
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexandear alexandear alexandear left review comments

@jandubois jandubois jandubois left review comments

@AkihiroSuda AkihiroSuda AkihiroSuda approved these changes

@nirs nirs Awaiting requested review from nirs

Assignees
No one assigned
Labels
area/cli limactl CLI user experience
Projects
None yet
Milestone
v1.0.3
Development

Successfully merging this pull request may close these issues.
5 participants
@olamilekan000 @jandubois @nirs @alexandear @AkihiroSuda