change make logs quiet by default and adds a verbose flag to enable v…

…erbose log output

Signed-off-by: olalekan odukoya <[email protected]>

cmd/limactl/copy.go

@@ -33,6 +33,7 @@ func newCopyCommand() *cobra.Command {
 	}
 
 	copyCommand.Flags().BoolP("recursive", "r", false, "copy directories recursively")
+	copyCommand.Flags().BoolP("verbose", "v", false, "enable verbose output")
 
 	return copyCommand
 }
@@ -43,23 +44,33 @@ func copyAction(cmd *cobra.Command, args []string) error {
 		return err
 	}
 
-	arg0, err := exec.LookPath("scp")
+	verbose, err := cmd.Flags().GetBool("verbose")
 	if err != nil {
 		return err
 	}
-	instances := make(map[string]*store.Instance)
-	scpFlags := []string{}
-	scpArgs := []string{}
+
 	debug, err := cmd.Flags().GetBool("debug")
+	if err == nil && debug {
+		verbose = true
+	}
+
+	arg0, err := exec.LookPath("scp")
 	if err != nil {
 		return err
 	}
-	if debug {
-		scpFlags = append(scpFlags, "-v")
+
+	instances := make(map[string]*store.Instance)
+	scpFlags := []string{}
+	scpArgs := []string{}
+
+	if !verbose {
+		scpFlags = append(scpFlags, "-q")
 	}
+
 	if recursive {
 		scpFlags = append(scpFlags, "-r")
 	}
+
 	legacySSH := sshutil.DetectOpenSSHVersion().LessThan(*semver.New("8.0.0"))
 	for _, arg := range args {
 		path := strings.Split(arg, ":")
@@ -117,9 +128,11 @@ func copyAction(cmd *cobra.Command, args []string) error {
 
 	sshCmd := exec.Command(arg0, append(sshArgs, scpArgs...)...)
 	sshCmd.Stdin = cmd.InOrStdin()
-	sshCmd.Stdout = cmd.OutOrStdout()
-	sshCmd.Stderr = cmd.ErrOrStderr()
-	logrus.Debugf("executing scp (may take a long time)): %+v", sshCmd.Args)
+	if verbose {
+		sshCmd.Stdout = cmd.OutOrStdout()
+		sshCmd.Stderr = cmd.ErrOrStderr()
+		logrus.Debugf("executing scp (may take a long time): %+v", sshCmd.Args)
+	}
 
 	// TODO: use syscall.Exec directly (results in losing tty?)
 	return sshCmd.Run()