-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Redesign the app (un)install receiver #100
base: master
Are you sure you want to change the base?
Redesign the app (un)install receiver #100
Conversation
4b7f6a4
to
1350adb
Compare
fc8a845
to
e6466af
Compare
Okay i've tested this once now for Oreo and it did't work right; |
This commit could be applied as is and work correctly if you would be ready to roll back to targeting SDK Version 25 again @ligi. Otherwise I don't see any reason to target Oreo and since it's majorly breaking app refreshing functionality as it is implemented right now (even on master) so rolling back and merging this would really be better in my opinion. [The lazy solution] |
Unfortunately I need to target 26 now if I want to upload to google play: |
Just saw it in Android Lint too .-. I see three options:
|
I would really like to let f-droid version and google play not drift apart - this only makes problems in the long run. |
Okay, digging into it. |
e6466af
to
66ad62b
Compare
If anyone can, please test this patch so it will prove to be stable enough for merge. |
b953f4d
to
bcce4b8
Compare
I consider this patch complete now. This means it is not ready for merge but should be fully functional and that any changes from this point will only be code cleanup and bug fixes. |
Another thing: As you can see in the change listing, some changes in my commit result from using the "Reformat Code" action in Android Studio (with default settings). Of course this is out of scope of this commit and will be removed before merge. I would nontheless welcome it if generally all FAST code would be reformatted in a dedicated commit to follow at least some code style. After all, it should make life easier for everyone working with FAST source code. What do you think @ligi? Is this a good suggestion or do you want to keep all existing code as is and only apply style guidelines to newly contributed code? |
bcce4b8
to
0f0443e
Compare
Side note... I F*in love this app, and now SebiderSushi too for all your efforts! :D |
its code is entirely duplicated in AppInfoListStore
Package IDs may only contain [a-zA-Z0-9_] https://developer.android.com/studio/build/configure-app-module
0b19f51
to
ac59ace
Compare
Issues covered: closes #94 closes #113 closes #114
PRs included: closes #110
Feature branches included: SebiderSushi:fix_installtime_froyo_catchblock