Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doesn't refresh newly installed apps. #113

Open
nihal697 opened this issue Feb 22, 2019 · 42 comments · May be fixed by #100
Open

doesn't refresh newly installed apps. #113

nihal697 opened this issue Feb 22, 2019 · 42 comments · May be fixed by #100

Comments

@nihal697
Copy link

Fast doesn't recognize newly installed apps. so to do that I have to clear cache in settings of the app but that also resets sorting of apps and the apps I pinned to the top. Please look into this issue.

@SebiderSushi
Copy link
Contributor

SebiderSushi commented Feb 22, 2019

This is a known issue. FAST has quite some problems with automatic refreshing of apps that i once attempted to fix in my own fork but i couldn't yet make it compatible with android oreo and the changes also haven't been merged.

In the meantime as a workaround you can use the fact that FAST refreshes on a new start and ends the main activity when entering the settings. So going to settings and back right away will trigger a refresh without the need to clear any data.

Or, if you are familiar with compiling android apps and don't run Android Oreo or newer you could go ahead and compile for yourself with my changes.

@nihal697
Copy link
Author

Oh, didn't know that. Thanks for replying so fast.
I have one suggestion also, should I say it here or in the pull request section?

@SebiderSushi
Copy link
Contributor

If your suggestion concerns something to be implemented into the pull request then i think you should post it there.
I'm glad to help ^^

@nihal697
Copy link
Author

Actually I am new here and I don't understand what exactly pull request means. So let me tell ny suggestion here and if it is inappropriate then I will delete it and add it to pull request.
Suggestion is to add a feature which opens apps automatically when the string of letters matches only a single app. I saw it on an open source app the link of whose sources I am providing here :
https://github.com/vackosar/search-based-launcher/
Tell me if I should delete it from here, please. Hope you like the idea.

@nihal697
Copy link
Author

I am literally sorry that I didn't notice it is already in the settings. Extremely sorry sir. (._.)

@SebiderSushi
Copy link
Contributor

No Problem, settings of new apps can be quite confusing sometimes. :D

@nihal697
Copy link
Author

Certainly it is. Thank you again. ❤️
Will close the issue as you said it is already known.

@SebiderSushi
Copy link
Contributor

I think you should leave it open until it is fixed for good.

@nihal697 nihal697 reopened this Feb 22, 2019
@nihal697
Copy link
Author

done.

@SebiderSushi SebiderSushi linked a pull request Feb 22, 2019 that will close this issue
@SebiderSushi
Copy link
Contributor

I've just completed my rework of FASTs app list update mechanisms. The only thing necessary now is to test it and polish it up before release. If you would want to test this it would greatly be appreciated as I can't properly test it under real life conditions since I don't use Android 8.0 or newer on my main device.
If you are familiar with building android apps go ahead and compile my feature branch.
If not, I have uploaded a testing build on my forked repository that can be installed alongside the official FAST application.

@nihal697
Copy link
Author

nihal697 commented May 12, 2019 via email

@nihal697
Copy link
Author

nihal697 commented May 12, 2019 via email

@SebiderSushi
Copy link
Contributor

Yes :)

@nihal697
Copy link
Author

nihal697 commented May 12, 2019 via email

@nihal697
Copy link
Author

nihal697 commented May 12, 2019 via email

@SebiderSushi
Copy link
Contributor

Very strange. But good that it worked anyway. Thank you very much for putting your trust and time into this and testing!

@nihal697
Copy link
Author

nihal697 commented May 12, 2019 via email

@SebiderSushi
Copy link
Contributor

But installing an app someone else built sure needs to happen out of at least a little bit of trust.

@nihal697
Copy link
Author

nihal697 commented May 12, 2019 via email

@nihal697
Copy link
Author

nihal697 commented Jun 3, 2019 via email

@SebiderSushi
Copy link
Contributor

Okay this should not happen.
Could you give the details specified in the last paragraph of the release notes of the testing build to give a clearer image?
Also if you might know anything that could be important when reproducing this bug that would be helpful too.

@nihal697
Copy link
Author

nihal697 commented Jun 8, 2019 via email

@SebiderSushi
Copy link
Contributor

Thank You very much for the information. I will look into it when i find the time.

@nihal697
Copy link
Author

nihal697 commented Jun 10, 2019 via email

@SebiderSushi
Copy link
Contributor

SebiderSushi commented Jun 30, 2019

Okay i have been using the testing build for about a week now since i finally have a daily driver phone running Oreo (more precisely LineageOS 15.1).
Having set Trebuchet as the default launcher i could not reproduce your observations, being FAST not recognizing an app being uninstalled from Trebuchet. May i ask which ROM you are using?

The only issue i found to be reproducible on my system seems to be that on Oreo FAST doesn't recognize it automatically if a "component" is enabled or disabled. For example there are Apps that offer to manually specify in their settings to hide or show one of their activities. I also found the error in the code that probably causes this and will fix it right now.

@SebiderSushi
Copy link
Contributor

SebiderSushi commented Jun 30, 2019

Correction: While investigating the issue of FAST not detecting components correctly i managed to reproduce your error: The issue i was investigating turned out to consist of two parts, one of them being the error in the code i already found and the other one being the issue you were observing.

The fixed version can now be downloaded from my release page (just pick the latest one).

Explanation

 It happended to be that if the list of changed packages was too short, then the refresh mechanism that should refresh only said changed packages on a fresh FAST launch (i.e. FAST has been terminated some time before) would be very quick. Due to a mistake i made this would lead to a situation where (i guess) somehow the mechanism would save the refreshed app list to disk while the user interface would have already loaded the previous version from disk and therefore keeps displaying that and then saves that outdated list later when you leave FAST, overwriting the refreshed list.
 I probably always (un)installed multiple apps while trying to reproduce your issue. In these cases the refreshing mechanism would take long enough for the user interface to completely initalize. At that point instead of writing the new list to disk, it will be sent directly to the running user interface and so the changes are applied.
 My fix simply consists in making sure that the callback resposible for sending the updated list directly to the user interface gets initialized before the updating mechanism is executed.

@nihal697
Copy link
Author

nihal697 commented Jul 2, 2019 via email

@nihal697
Copy link
Author

nihal697 commented Aug 17, 2022 via email

@SebiderSushi
Copy link
Contributor

I pushed a new build on my release page.
It's still not up to code but should work. I put together the existing code and fixed some bits here and there.

At some point i stopped using FAST and stopped working on the patch. It was left lingering for about 3 years now and is 5 years old in total. I wouldn't get my hopes up that it will ever get merged at this stage. Right now it is what it is but it should work pretty ok.

@nihal697
Copy link
Author

nihal697 commented Aug 21, 2022 via email

@SebiderSushi
Copy link
Contributor

SebiderSushi commented Aug 21, 2022

I'm using Lawnchair. The inability to use app shortcuts or widgets on FAST was always a bummer...


The TL;DR is: You likely only care about forFDroid-withExtras
If you're curious, build variants are different in these aspects:

The noExtras version is set up to get the app as small as possible. It is what you get when you download the app "FASTER" (org.ligi.faster on F-Droid).
 The are no translations and no "About" page (opened by tapping the question mark in the top bar in the full release).

Nowadays this build variant isn't really useful as almost no contemporary phone would notice a difference between a 60KB apk and a 90KB apk. But it can still be compiled so here we are.

The Amazon, F-Droid, Play variants are basically different in which link they use when you tap "Share" or where you get sent to when you tap "open in market" (only shown on apps that were installed by google play / amazon app store).

@nihal697
Copy link
Author

nihal697 commented Aug 21, 2022 via email

@nihal697
Copy link
Author

nihal697 commented Nov 8, 2022 via email

@SebiderSushi
Copy link
Contributor

I thought it could be useful to have fast in recents when not using it as a launcher but i can revert this change, sure. Can you go into more detail as to why it is a pain? I'd like to grasp this a little better.

As for a bottom-oriented layout, there's issue #66 which has been around since 2015. Again, there's not much going on with this project anymore. My intention is to finally finish my work that i started and make FAST at least usable even if it's still far from polished. The core of my changes still is "make FAST refresh the app list properly for once", the rest is what's required to even compile it and some low hanging fruit that i thought i just might fix along the way as well.

@nihal697
Copy link
Author

nihal697 commented Nov 8, 2022 via email

@SebiderSushi
Copy link
Contributor

  1. I realize that your default launcher should never appear on the recents screen, but from my testing i came to the conclusion that android already takes care of this situation. I tested my build on CyanogenMod 7 (android 2.3.7), LineageOS 15.1 (android 8.1) and LineageOS 18.1 (android 11) and all of these do not add FAST to the recents list if it is set as the default launcher. What android version by which vendor are you using?
  2. Using FAST as an assistant app is indeed a use case i did not test so far so i just tried it out.

After some tests i came to the conclusion that android does not offer any way to make FAST appear on the recents screen with just the regular launcher entry but not the Assist entry. I reverted the change and posted a new release.

@nihal697
Copy link
Author

nihal697 commented Nov 8, 2022 via email

@SebiderSushi
Copy link
Contributor

I can't reproduce this issue, but i don't have android 13.
You might have to remove FAST from recents and reboot after the update until it all woks as expected again - but that's a shot in the dark i have no clue what android 13 is doing here.

@nihal697
Copy link
Author

nihal697 commented Nov 8, 2022 via email

@SebiderSushi
Copy link
Contributor

v6.8-redesign-7 will show up on the recents screen just like any other app would, regardless of whether you navigated to the settings screen or not - that's expected behavior. The only exception is if android removes it because it is set as the default launcher app.

glad to hear that v6.8-redesign-8 works properly again.

@nihal697
Copy link
Author

nihal697 commented Nov 8, 2022 via email

@nihal697
Copy link
Author

nihal697 commented Jan 25, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants