Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pre-refactor for HTLC Interception #1840

Merged
merged 4 commits into from
Nov 9, 2022
Merged

Pre-refactor for HTLC Interception #1840

merged 4 commits into from
Nov 9, 2022

Commits on Nov 8, 2022

  1. Refactor HTLCForwardInfo::AddHTLC for intercept forwards 

    In upcoming commit(s), we'll want to store intercepted HTLC forwards in
ChannelManager before the user signals that they should be forwarded.  It
wouldn't make sense to store a HTLCForwardInfo as-is because the FailHTLC
variant doesn't make sense, so we refactor out the ::AddHTLC contents into its
own struct for storage.

Co-authored-by: John Cantrell <[email protected]>
Co-authored-by: Valentine Wallace <[email protected]>
    @valentinewallace @johncantrell97
    valentinewallace and johncantrell97 committed Nov 8, 2022
    Configuration menu
    Copy the full SHA
    582b827 View commit details
    Browse the repository at this point in the history

  2. Delete unnecessary whitespace in process_pending_forwards 

    Only whitespace diff
    @valentinewallace
    valentinewallace committed Nov 8, 2022
    Configuration menu
    Copy the full SHA
    b3d257d View commit details
    Browse the repository at this point in the history

  3. Track incoming amount in PendingHTLCInfo 

    Used in upcoming commit(s) when we generate the PaymentIntercepted event for
intercepted payments.

Co-authored-by: John Cantrell <[email protected]>
Co-authored-by: Valentine Wallace <[email protected]>
    @valentinewallace @johncantrell97
    valentinewallace and johncantrell97 committed Nov 8, 2022
    Configuration menu
    Copy the full SHA
    203394f View commit details
    Browse the repository at this point in the history

  4. Fix scid_utils::is_valid* false positive 

    cargo bench was able to find an scid of 0 as a valid fake scid
    @valentinewallace
    valentinewallace committed Nov 8, 2022
    Configuration menu
    Copy the full SHA
    c793549 View commit details
    Browse the repository at this point in the history