Pre-refactor for HTLC Interception #1840
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 90.77% // Head: 90.81% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1840 +/- ##
==========================================
+ Coverage 90.77% 90.81% +0.04%
==========================================
Files 87 87
Lines 47595 47727 +132
Branches 47595 47727 +132
==========================================
+ Hits 43204 43345 +141
+ Misses 4391 4382 -9
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
TheBlueMatt
reviewed
Nov 8, 2022
In upcoming commit(s), we'll want to store intercepted HTLC forwards in ChannelManager before the user signals that they should be forwarded. It wouldn't make sense to store a HTLCForwardInfo as-is because the FailHTLC variant doesn't make sense, so we refactor out the ::AddHTLC contents into its own struct for storage. Co-authored-by: John Cantrell <[email protected]> Co-authored-by: Valentine Wallace <[email protected]>
Only whitespace diff
Used in upcoming commit(s) when we generate the PaymentIntercepted event for intercepted payments. Co-authored-by: John Cantrell <[email protected]> Co-authored-by: Valentine Wallace <[email protected]>
cargo bench was able to find an scid of 0 as a valid fake scid
valentinewallace
force-pushed
the
2022-11-htlc-intercept-prefactor
branch
from
3114857
to
c793549
Compare
TheBlueMatt
approved these changes
Nov 8, 2022
dunxen
approved these changes
Nov 9, 2022
TheBlueMatt
reviewed
Nov 9, 2022
| @@ -2194,6 +2197,7 @@ impl<M: Deref, T: Deref, K: Deref, F: Deref, L: Deref> ChannelManager<M, T, K, F | |||
| routing, | |||
| payment_hash, | |||
| incoming_shared_secret: shared_secret, | |||
| amt_incoming: Some(amt_msat), | |||
There was a problem hiding this comment.
In a followup, lets rename this incoming_amt_msat and the following to_forward_amt_msat or just some ther names with msat in them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clears the path for #1835 to have a smaller changeset there.
If we want, I can also pull in bcac847 which tracks pending intercepts in
ChannelManager(though none will be tracked until 1835).