Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MetaMask and Browser Extension wallet adapters #113

Merged
merged 15 commits into from
Jan 15, 2024

Conversation

alx-khramov
Copy link
Contributor

@alx-khramov alx-khramov commented Dec 21, 2023

This PR:

  • reworks MetaMask connection to use wagmi, add wallet adapter
  • fixes a bug when it wasn't possible to choose another MetaMask account after disconnect
  • adds a generic Browser Extension wallet connection for EIP-1193 Injected type of wallets
  • fixes types after updating @types/react to v18
  • deprecates wallets-icons package
  • fixes the issue with static imports of ledger libs, which are significantly bloating the main js chunk (see screenshots below)
Before the ledger imports fix

image

After the ledger imports fix

image

Resolve SI-995, SI-973, SI-992, SI-1106

@alx-khramov alx-khramov self-assigned this Dec 21, 2023
@alx-khramov alx-khramov requested a review from a team as a code owner December 21, 2023 19:42
Copy link

changeset-bot bot commented Dec 21, 2023

⚠️ No Changeset found

Latest commit: 2ffb96f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

apps/demo-react/components/MainSection.tsx Outdated Show resolved Hide resolved
packages/core-react/src/context/reefKnot.tsx Show resolved Hide resolved
packages/web3-react/src/context/connectors.tsx Outdated Show resolved Hide resolved
packages/web3-react/src/context/web3.tsx Outdated Show resolved Hide resolved
Base automatically changed from feature/ledger-connector-rework to main December 22, 2023 12:35
@alx-khramov alx-khramov force-pushed the feature/metamask-and-injected-adapters branch from 2af1bd2 to ac2d9c1 Compare December 22, 2023 17:59
Jeday
Jeday previously approved these changes Dec 25, 2023
@alx-khramov alx-khramov merged commit 9082c62 into main Jan 15, 2024
1 check passed
@alx-khramov alx-khramov deleted the feature/metamask-and-injected-adapters branch January 15, 2024 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants