fix: fixes after code review

lidofinance · Dec 22, 2023 · ac2d9c1 · ac2d9c1
1 parent 253796d
commit ac2d9c1
Show file tree

Hide file tree

Showing 6 changed files with 7 additions and 7 deletions.
diff --git a/apps/demo-react/components/MainSection.tsx b/apps/demo-react/components/MainSection.tsx
@@ -1,8 +1,8 @@
-import React from 'react';
+import { ReactNode } from 'react';
 import { Section } from '@lidofinance/lido-ui';
 import { MainSection } from '../styles/global';
 
-const Main = ({ children }: { children: React.ReactNode }) => {
+const Main = ({ children }: { children?: ReactNode }) => {
   return (
     <Section>
       <MainSection>{children}</MainSection>

diff --git a/apps/demo-react/components/contractTesting/Wrap.tsx b/apps/demo-react/components/contractTesting/Wrap.tsx
@@ -74,7 +74,7 @@ const WrapForm = ({
   const handleWrapSelectChange = (value: OptionValue) => {
     setWrapSelect(value as string);
   };
-  const handleWrapCoinChange = (value: any) => {
+  const handleWrapCoinChange = (value: string | number) => {
     setWrapCoin(`${value}`);
     setInputValue('0.00001');
   };

diff --git a/apps/demo-react/hooks/useWithdrawalsData.ts b/apps/demo-react/hooks/useWithdrawalsData.ts
@@ -198,7 +198,7 @@ export const useWithdrawalRequestMethods = () => {
   );
 
   const steth = useCallback(
-    async ({ requests }: { requests: any }) => {
+    async ({ requests }: { requests: BigNumberish[] }) => {
       const params = [requests, account || ''] as const;
 
       const callback = async () => {

diff --git a/packages/connect-wallet-modal/src/components/WalletsModal/WalletsModal.tsx b/packages/connect-wallet-modal/src/components/WalletsModal/WalletsModal.tsx
@@ -149,5 +149,5 @@ export function WalletsModal(props: WalletsModalProps) {
     }
   }
 
-  return <></>;
+  return null;
 }
diff --git a/packages/web3-react/src/context/connectors.tsx b/packages/web3-react/src/context/connectors.tsx
@@ -8,7 +8,7 @@ import { useAutoConnect } from '../hooks/useAutoConnect';
 import { CONNECTOR_NAMES } from '../constants';
 
 export interface ConnectorsContextProps {
-  children: React.ReactNode;
+  children?: React.ReactNode;
   defaultChainId: CHAINS;
   rpc: Record<number, string>;
   appName?: string;

diff --git a/packages/web3-react/src/context/web3.tsx b/packages/web3-react/src/context/web3.tsx
@@ -18,7 +18,7 @@ import { POLLING_INTERVAL } from '../constants';
 import ProviderConnectors, { ConnectorsContextProps } from './connectors';
 
 export interface ProviderWeb3Props extends ConnectorsContextProps {
-  children: React.ReactNode;
+  children?: React.ReactNode;
   defaultChainId: CHAINS;
   supportedChainIds: CHAINS[];
   swrConfig?: SWRConfiguration;