Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicate check from wfe.FinalizeOrder #7987

Merged
merged 3 commits into from
Jan 30, 2025
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Remove duplicate check from wfe.FinalizeOrder
This check is duplicated in the next stanza.
aarongable authored Jan 30, 2025

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
commit f2f8070390c317e8805b4181e7b0212c9afa5665
5 changes: 0 additions & 5 deletions wfe2/wfe.go
Original file line number Diff line number Diff line change
@@ -2490,7 +2490,7 @@
wfe.sendError(response, logEvent, probs.NotFound("Invalid request path"), nil)
return
}
acctID, err := strconv.ParseInt(fields[0], 10, 64)

Check failure on line 2493 in wfe2/wfe.go

GitHub Actions / govulncheck

declared and not used: acctID
if err != nil {
wfe.sendError(response, logEvent, probs.Malformed("Invalid account ID"), nil)
return
@@ -2517,11 +2517,6 @@
return
}

if order.RegistrationID != acctID {
wfe.sendError(response, logEvent, probs.NotFound(fmt.Sprintf("No order found for account ID %d", acctID)), nil)
return
}

// If the authenticated account ID doesn't match the order's registration ID
// pretend it doesn't exist and abort.
if acct.ID != order.RegistrationID {