Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicate check from wfe.FinalizeOrder #7987

Merged
merged 3 commits into from
Jan 30, 2025
Merged

Conversation

aarongable
Copy link
Contributor

@aarongable aarongable commented Jan 30, 2025

This check is duplicated in the next stanza. Instead, replace it with a check that the acctID encoded in the URL and the acctID corresponding to the JWS used to sign the request match.

This check is duplicated in the next stanza.
@aarongable aarongable requested a review from a team as a code owner January 30, 2025 00:15
@aarongable aarongable requested a review from jsha January 30, 2025 00:15
Copy link
Contributor

@jsha jsha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR description should also mention the newly added check.

@aarongable aarongable requested a review from jprenken January 30, 2025 19:27
@aarongable aarongable merged commit 1ae1847 into main Jan 30, 2025
12 checks passed
@aarongable aarongable deleted the aarongable-patch-1 branch January 30, 2025 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants