-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate test from enzyme to vue testing library #897
base: develop
Are you sure you want to change the base?
Conversation
cc @EshaanAgg if you're around and would like to join review, you're very welcome |
Thank you @Pandaa007! |
Immediate implications, no - because this is only a dev dependency, so doesn't affect what gets installed in Kolibri and Studio. This PR (and the NodeJS upgrade) was the only prerequisite to doing this dependency upgrade so this should be OK within KDS itself. The main thing is that node-sass was incredibly outdated, had quite a few bugs, and also missing some SASS language features. I think we might have noticed, but it is possible that switching to But any merge of this should open correlated issues for sass upgrade on those two repos. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Pandaa007! The PR looks great.
I have added a small nit related to the event simulation package, so it would be really helpful if you can address that!
Also, might be a bit unrelated to this PR, but it might be nice to have the eslint-plugin-jest-dom
also configured in the repository now, as the same ensures that our tests are using the correct custom matcher's wherever possible! Would greatly appreciate if you can install the same and configure it as well!
As always, if you feel stuck, please do not hesitate to reach out for help!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making the changes @Pandaa007! The PR looks good to me now! You can now wait for approval from other members of the team.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On code review, this LGTM - I'm a big fan of how the updated tests are more readable overall and it's a great start of a migration.
Hey! Thanks @AlexVelezLl for your kind patience! I have rebased the PR appropriately and made the changes as well. There are two design designs that I have taken in this PR that might be of relevance:
The PR is now ready for review. Thank you all for working with me on this PR. |
Description
Issue addressed
Fixes #510
Changelog
Testing checklist
Reviewer guidance
Comments