Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade color package #740

Open
MisRob opened this issue Aug 21, 2024 · 7 comments
Open

Upgrade color package #740

MisRob opened this issue Aug 21, 2024 · 7 comments
Assignees
Labels
dependencies Pull requests that update a dependency file

Comments

@MisRob
Copy link
Member

MisRob commented Aug 21, 2024

Summary

In #728, we introduced color version 3.2.1 because newer versions required Node > 12 (ref).

We shouldn't update it sooner than #645 is merged. Then, it would ideally update it to the newest version.

@MisRob MisRob added the dependencies Pull requests that update a dependency file label Aug 21, 2024
@AlexVelezLl
Copy link
Member

Hi! Just a heads up that now this issue is unblocked, as we finally have updated KDS to node v18 :)

@AlexVelezLl AlexVelezLl changed the title Upgrade color package after Node v18 upgrade Upgrade color package Dec 10, 2024
@Pandaa007
Copy link

Hello @MisRob and @AlexVelezLl, I would really like to work on this issue. Can you please assign it to me?

@MisRob
Copy link
Member Author

MisRob commented Jan 14, 2025

Hi @Pandaa007, yes, please try to upgrade the color package to the latest version and after the upgrade, you'd want to check that the $darken utilities introduced in #728 still work. You can use the playground page for that.

@Pandaa007
Copy link

Hello @MisRob thank you for assigning this issue to me. I look forward to working and sharing my updates.

@akolson
Copy link
Member

akolson commented Jan 15, 2025

HI @Pandaa007!

Please be sure to let us know in case you have any questions or comments. We look forward to collaborating with you too.

Thank you!

@Pandaa007
Copy link

Small update: Waiting for my PR #897 to be merged before I start working on this issue, as in that PR I point our some issues related to the deprecated of the node-sass package and replacing it with sass package. Once the team decides on which package to keep in that PR, I would follow the same guidance in this PR as well to avoid unnecessary changes to the yarn.lock.

@MisRob
Copy link
Member Author

MisRob commented Jan 21, 2025

Thanks for letting us know @Pandaa007! We will follow-up with you on the decision.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

No branches or pull requests

4 participants