Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#145 ignore empty questions inserting editing intents #161

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

Miguel-Alves
Copy link
Collaborator

According to the needs of #145, this PR is solving the problems described.

  • Now, when inserting or editting an intent, the user can leave empty ballons (as longs as they are not the only content), so it continues to stimulate him to add more content;
  • Empty ballons are not saved to the database anymore;
  • If present, empty balloons are removed from the utters upon loading;

This Pull Request resolves #145

Copy link
Collaborator

@gabibguedes gabibguedes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I couldn't get it to work properly, it still doesn't let me save intents with empty baloons.

@@ -1,4 +1,4 @@
export const BASE = process.env.REACT_APP_URL_API + 'api/v1/';
export const BASE = 'http://localhost:8000/api/v1/';
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change it back to the env variable, with it we can set the API endpoint on production environments

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gabibguedes are you using the dev environment or the docker?
Until the docker problem is solved, using the docker is not possible cause it doesnt reflect changes we made to the code.
Also, as the docker doesnt work properly, we need this variable set this way as described on #157

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ignore empty questions when inserting/editing intents
2 participants