Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore empty questions when inserting/editing intents #145

Open
3 tasks done
rodmaia opened this issue Feb 11, 2021 · 7 comments · May be fixed by #161
Open
3 tasks done

Ignore empty questions when inserting/editing intents #145

rodmaia opened this issue Feb 11, 2021 · 7 comments · May be fixed by #161
Assignees

Comments

@rodmaia
Copy link
Collaborator

rodmaia commented Feb 11, 2021

When inserting or editing an intent you can have text fields that are completely empty or that only have a [space] character inside. These balloons should be:

  • ignored by the front-end validation
  • not saved to the database
  • removed from the utter if present upon loading

With the exception of intents whose entire content is a single empty text field. In that case, validation should continue preventing to save that intent.

Different from the utters, intents can continue to show the empty textfields on screen to stimulate people to add more question examples.

Tasks

  • TBD

Acceptance criteria

  • Empty question examples are not saved to the database
  • Empty question examples are not loaded from the database
@Miguel-Alves
Copy link
Collaborator

Nice! Working on it

@rodmaia
Copy link
Collaborator Author

rodmaia commented Feb 19, 2021

@Miguel-Alves assign the issue to yourself if you are working on it 😉

Let me know if you can expose your dev environment to the web. I’d like to test it to ensure the original idea on the issue makes sense.

@Miguel-Alves Miguel-Alves self-assigned this Feb 24, 2021
@Miguel-Alves
Copy link
Collaborator

Miguel-Alves commented Feb 24, 2021

Done. Assigned it to myself and moved it to "In Progress" board.

About exposing my dev environment, how would you like me to do it?

@Miguel-Alves
Copy link
Collaborator

Miguel-Alves commented Feb 25, 2021

Reviewing this issue based on #153;

@rodmaia
Copy link
Collaborator Author

rodmaia commented Feb 25, 2021

About exposing my dev environment, how would you like me to do it?

As we agreed on Telegram, let's do a video call to go over this.

@Miguel-Alves
Copy link
Collaborator

Miguel-Alves commented Mar 2, 2021

Following the procedures from #153 , this issue was maintained;

@Miguel-Alves
Copy link
Collaborator

Solved this issue as described in #161

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants