[pt-PT] Removed temp_off from subrule in rule ID:INFORMALITIES #10914
Conversation
WalkthroughThe pull request introduces significant updates to the Changes
Possibly related PRs
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (1)
languagetool-language-modules/pt/src/main/resources/org/languagetool/rules/pt/pt-PT/style.xml (1)
Line range hint
1-1885: File structure and organization suggestionsWhile the specific change requested in this pull request has been implemented correctly, I have some general observations about the file:
The file is quite large and contains numerous rules and antipatterns. Consider splitting this file into smaller, more manageable files based on rule categories or types to improve maintainability.
Many rules use hardcoded lists of words or expressions. Consider moving these lists to separate resource files or databases to make updates and maintenance easier.
The file contains a mix of comments in English and Portuguese. For consistency and ease of international collaboration, consider using a single language (preferably English) for all comments and documentation.
Some rules have extensive antipatterns. While these are necessary for accuracy, they can make the rules harder to read and maintain. Consider refactoring complex rules into multiple simpler rules where possible.
The file uses a combination of XML attributes and child elements for defining rule properties. For consistency, consider standardizing on one approach throughout the file.
These suggestions are not directly related to the current pull request but could be considered for future improvements to enhance the overall maintainability and readability of the codebase.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (1)
- languagetool-language-modules/pt/src/main/resources/org/languagetool/rules/pt/pt-PT/style.xml (1 hunks)
🔇 Additional comments (1)
languagetool-language-modules/pt/src/main/resources/org/languagetool/rules/pt/pt-PT/style.xml (1)
Line range hint
1879-1885: Removal of temporary deactivation for a subruleThe
temp_offattribute has been removed from the following subrule:<rule> <pattern> <token inflected='yes'>dar</token> <token>uma</token> <token>volta</token> <token>ao</token> <token>bilhar</token> <token>grande</token> </pattern> <message>&colloquialism_msg;</message> <short>Coloquialismo</short> <example correction=''>Vai <marker>dar uma volta ao bilhar grande</marker>.</example> </rule>This change indicates that the rule is now active and will flag the colloquial expression "dar uma volta ao bilhar grande" as informal language. This is consistent with the purpose of the INFORMALITIES rule group, which aims to identify and suggest alternatives for informal language usage.
Just removed “temp_off”
Summary by CodeRabbit