Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pt-PT] Moved rule ID:INFORMALITIES into category ID:FORMAL_SPEECH_PT_PT #10929

Merged
merged 1 commit into from
Oct 13, 2024

Conversation

marcoagpinto
Copy link
Member

@marcoagpinto marcoagpinto commented Oct 13, 2024

Part 1 of 2: moved rulegroup into the correct category. Tomorrow I will break it into two.

Summary by CodeRabbit

  • New Features

    • Introduced new rules for formalizing idiomatic expressions and improving address formatting in Portuguese.
    • Added rules to simplify expressions and suggest more formal alternatives for colloquial phrases.
  • Modifications

    • Expanded existing rules for clarity and specificity, including updated suggestions for common phrases.
  • Bug Fixes

    • Removed redundant or less relevant rules to enhance overall language processing quality.

Copy link
Contributor

coderabbitai bot commented Oct 13, 2024

Walkthrough

The pull request introduces significant updates to the style.xml file for Portuguese language rules in LanguageTool. It includes the addition of new rules aimed at formalizing expressions and improving address formatting, modifications to existing rules for clarity and specificity, and the removal of redundant rules. The overall structure of the XML document was also adjusted to maintain organization and adherence to the expected schema.

Changes

File Path Change Summary
languagetool-language-modules/pt/src/main/resources/org/languagetool/rules/pt/pt-PT/style.xml - Added new rules for idiomatic expressions, address formatting, and simplification of terms.
- Modified existing rules for clarity, including updates to phrases and formal alternatives.
- Removed several redundant rules.
- Adjusted overall XML structure for organization.

Possibly related PRs

Suggested reviewers

  • p-goulart
  • susanaboatto

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between bf9c345 and 158c492.

📒 Files selected for processing (1)
  • languagetool-language-modules/pt/src/main/resources/org/languagetool/rules/pt/pt-PT/style.xml (2 hunks)
🧰 Additional context used
🔇 Additional comments (4)
languagetool-language-modules/pt/src/main/resources/org/languagetool/rules/pt/pt-PT/style.xml (4)

Line range hint 1-24: LGTM: XML declaration, stylesheets, and copyright information

The XML declaration, stylesheet references, and copyright notice are all in order. This section provides essential information about the file's purpose and licensing.


Line range hint 26-95: LGTM: DOCTYPE and entity definitions

The DOCTYPE declaration and entity definitions are well-structured and comprehensive. They include both external entity files and direct entity definitions specific to Portuguese language rules.


Line range hint 97-647: LGTM: 'rules' element and initial category structure

The 'rules' element and the first category for style rules are well-structured. The individual rules within the category appear to address specific language usage issues, which is appropriate for a style rule set.


374-387: LGTM: New rule 'VELHA_ESCOLA_VELHA_GUARDA'

The newly added rule for replacing "velha escola" with "velha guarda" is well-structured and consistent with the file's purpose of improving formal language usage.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@marcoagpinto marcoagpinto merged commit 3c9e306 into master Oct 13, 2024
5 checks passed
@marcoagpinto marcoagpinto deleted the lt_marcoagpinto_20241013_1946 branch October 13, 2024 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant