Gas usage comparisson between P256Verify precompile implementations (benchmark)

Makefile

@@ -1,4 +1,4 @@
-.PHONY: setup update run test docs
+.PHONY: setup update run test docs clean compilers get-zksolc get-zkvyper get-vyper benches
 
 setup:
 	git submodule update --init && \
@@ -29,3 +29,17 @@ docs:
 
 clean:
 	rm submodules/era-test-node/src/deps/contracts/*.yul.zbin submodules/era-test-node/etc/system-contracts/contracts/precompiles/*.yul
+
+compilers: get-zksolc get-zkvyper get-vyper
+
+get-zksolc:
+	wget 'https://github.com/matter-labs/zksolc-bin/raw/main/macosx-arm64/zksolc-macosx-arm64-v1.3.14' -O ~/Library/Application\ Support/eth-compilers/zksolc
+
+get-zkvyper:
+	wget 'https://github.com/matter-labs/zkvyper-bin/blob/main/macosx-arm64/zkvyper-macosx-arm64-v1.3.13' -O ~/Library/Application\ Support/eth-compilers/zkvyper
+
+get-vyper:
+	wget 'https://github.com/vyperlang/vyper/releases/download/v0.3.10/vyper.0.3.10+commit.91361694.darwin' -O ~/Library/Application\ Support/eth-compilers/vyper
+
+benches:
+	make test PRECOMPILE=p256verify_bench

precompiles/Modexp.yul

@@ -760,6 +760,10 @@ object "ModExp" {
             let limbsExpLen, misalignment := bigIntLimbs(expLen)
             let limbsModLen, misalignment := bigIntLimbs(modLen)
 
+            if and(and(eq(limbsBaseLen, 1), eq(limbsExpLen, 1)), eq(limbsModLen, 1)) {
+                oneLimbImplementation()
+            }
+
             let ptrBaseLimbs
             parseCalldata(basePtr, baseLen, ptrBaseLimbs)
 

scripts/p256verify_daimo_tests.py

@@ -60,7 +60,7 @@ def write_test_suit(test_suit_data, test_file: io.TextIOWrapper):
     for test_case in test_suit_data:
         write_test_case("P256VERIFTY_PRECOMPILE_ADDRESS", test_case, test_file)
 
-def main():
+def write_daimo_tests():
     test_case_data = []
     for test_path in TESTS_PATHS:
         with open(test_path, "r") as entry_file:
@@ -89,5 +89,37 @@ def main():
 
             write_test_suit(test_case_data, open("tests/tests/p256verify_daimo_tests.rs", "w"))
 
+def gen_valid_test_cases_calldata():
+    test_cases_calldata = []
+    for test_path in TESTS_PATHS:
+        with open(test_path, "r") as entry_file:
+            data = json.load(entry_file)
+            i = 0
+            for test_case in data:
+                hash = test_case["hash"]
+                r = test_case["r"]
+                s = test_case["s"]
+                x = test_case["x"]
+                y = test_case["y"]
+
+                calldata = hash + r + s + x + y
+
+                if "wycheproof" in entry_file.name:    
+                    comment = test_case["comment"]
+                    valid = test_case["valid"]
+                    name = f"wycheproof_{i}_{'should_fail' if not valid else 'should_pass'}"
+                    i += 1
+                else:
+                    name = "_".join(test_case["comment"].split(" "))
+                    valid = True
+                    comment = None
+                if valid:
+                    test_cases_calldata.append(calldata)
+    with open("assets/benches_calldata.json", "w") as benches_calldata:
+        json.dump(test_cases_calldata, benches_calldata)
+
+def main():
+    gen_valid_test_cases_calldata()
+
 if __name__ == "__main__":
     main()

tests/build.rs

@@ -15,6 +15,7 @@ fn main() {
         "p256verify".to_string(),
         "secp256k1verify".to_string(),
         "verifier".to_string(),
+        "p256verify_benches_report".to_string(),
     ];
     precompiles_report_list
         .into_iter()