Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gas usage comparisson between P256Verify precompile implementations (benchmark) #180

Open
wants to merge 51 commits into
base: main
Choose a base branch
from
Open

Gas usage comparisson between P256Verify precompile implementations (benchmark) #180

wants to merge 51 commits into from

Commits on Nov 1, 2023

  1. Add test contracts

    @ilitteri
    ilitteri committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    49a89da View commit details
    Browse the repository at this point in the history

  2. Add compiler module

    @ilitteri
    ilitteri committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    8bbe8ab View commit details
    Browse the repository at this point in the history

  3. Add local_wallet to utils

    @ilitteri
    ilitteri committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    88dd6ca View commit details
    Browse the repository at this point in the history

  4. Update deps

    @ilitteri
    ilitteri committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    4e62bd6 View commit details
    Browse the repository at this point in the history

  5. Add integration tests

    @ilitteri
    ilitteri committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    8390379 View commit details
    Browse the repository at this point in the history

  6. Add compiler module to lib

    @ilitteri
    ilitteri committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    5af4ae5 View commit details
    Browse the repository at this point in the history

  7. cargo fmt

    @ilitteri
    ilitteri committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    ee74e5b View commit details
    Browse the repository at this point in the history

  8. Update deps

    @ilitteri
    ilitteri committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    b239b76 View commit details
    Browse the repository at this point in the history

  9. Remove log usage

    @ilitteri
    ilitteri committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    7201ab4 View commit details
    Browse the repository at this point in the history

  10. Fix tests

    @ilitteri
    ilitteri committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    51b3955 View commit details
    Browse the repository at this point in the history

  11. Add comment explaining where we got the calldata from

    @jrchatruc
    jrchatruc committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    2f9092a View commit details
    Browse the repository at this point in the history

  12. clippy

    @jrchatruc
    jrchatruc committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    b039c79 View commit details
    Browse the repository at this point in the history

Commits on Nov 2, 2023

  1. Add cheaper modexp version

    @ilitteri
    ilitteri committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    5d5f243 View commit details
    Browse the repository at this point in the history

  2. Update integration tests

    @ilitteri
    ilitteri committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    26904fd View commit details
    Browse the repository at this point in the history

  3. Add clean cmd in Makefile

    @ilitteri
    ilitteri committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    79ae22a View commit details
    Browse the repository at this point in the history

  4. Update era-test-node commit

    @ilitteri
    ilitteri committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    e62dd8b View commit details
    Browse the repository at this point in the history

  5. cargo fmt

    @ilitteri
    ilitteri committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    f8950d6 View commit details
    Browse the repository at this point in the history

  6. Add new verifier test

    @jrchatruc
    jrchatruc committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    7c456fb View commit details
    Browse the repository at this point in the history

  7. Fix 1 limb modexp tests

    @ilitteri
    ilitteri committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    076f772 View commit details
    Browse the repository at this point in the history

  8. Update cheap modexp

    @ilitteri
    ilitteri committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    035faa8 View commit details
    Browse the repository at this point in the history

  9. Update era-test-node commit

    @ilitteri
    ilitteri committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    73fbe5e View commit details
    Browse the repository at this point in the history

  10. Update era-test-node commit

    @ilitteri
    ilitteri committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    230c131 View commit details
    Browse the repository at this point in the history

Commits on Nov 3, 2023

  1. Update Verifier's vk with a test one

    @ilitteri
    ilitteri committed Nov 3, 2023
    Configuration menu
    Copy the full SHA
    992e904 View commit details
    Browse the repository at this point in the history

  2. write_verifier_gas_result on new verifier

    @ilitteri
    ilitteri committed Nov 3, 2023
    Configuration menu
    Copy the full SHA
    cc94578 View commit details
    Browse the repository at this point in the history

  3. Update run cmd

    @ilitteri
    ilitteri committed Nov 3, 2023
    Configuration menu
    Copy the full SHA
    c8f3a22 View commit details
    Browse the repository at this point in the history

  4. Add comments to tests

    @ilitteri
    ilitteri committed Nov 3, 2023
    Configuration menu
    Copy the full SHA
    a9574e0 View commit details
    Browse the repository at this point in the history

  5. Ignore new_verifier_fails

    @ilitteri
    ilitteri committed Nov 3, 2023
    Configuration menu
    Copy the full SHA
    4af0fd7 View commit details
    Browse the repository at this point in the history

  6. cargo fmt & clippy

    @ilitteri
    ilitteri committed Nov 3, 2023
    Configuration menu
    Copy the full SHA
    b02728b View commit details
    Browse the repository at this point in the history

  7. Add P256 verifier contracts

    @ilitteri
    ilitteri committed Nov 3, 2023
    Configuration menu
    Copy the full SHA
    40dfb83 View commit details
    Browse the repository at this point in the history

  8. Add p256verify bench

    @ilitteri
    ilitteri committed Nov 3, 2023
    Configuration menu
    Copy the full SHA
    e9ddab2 View commit details
    Browse the repository at this point in the history

  9. Change modexp precompile to switch to the simple implementation if ev… 

    …ery argument is just one limb long
    @jrchatruc
    jrchatruc committed Nov 3, 2023
    Configuration menu
    Copy the full SHA
    25599c7 View commit details
    Browse the repository at this point in the history

  10. Go back to call modexp

    @ilitteri
    ilitteri committed Nov 3, 2023
    Configuration menu
    Copy the full SHA
    18ed01b View commit details
    Browse the repository at this point in the history

  11. Implement naive compile_zkvyper

    @ilitteri
    ilitteri committed Nov 3, 2023
    Configuration menu
    Copy the full SHA
    264409c View commit details
    Browse the repository at this point in the history

  12. Merge branch 'add_verifier_integration_test' of github.com:lambdaclas… 

    …s/zksync_era_precompiles into p256verify_benches
    @ilitteri
    ilitteri committed Nov 3, 2023
    Configuration menu
    Copy the full SHA
    dad7224 View commit details
    Browse the repository at this point in the history

  13. Add vyper implementation to bench

    @ilitteri
    ilitteri committed Nov 3, 2023
    Configuration menu
    Copy the full SHA
    6679b99 View commit details
    Browse the repository at this point in the history

Commits on Nov 6, 2023

  1. Add benches report

    @ilitteri
    ilitteri committed Nov 6, 2023
    Configuration menu
    Copy the full SHA
    d9f20df View commit details
    Browse the repository at this point in the history

  2. Finish benchmark setup

    @ilitteri
    ilitteri committed Nov 6, 2023
    Configuration menu
    Copy the full SHA
    9beb478 View commit details
    Browse the repository at this point in the history

  3. Generate calldata vector

    @ilitteri
    ilitteri committed Nov 6, 2023
    Configuration menu
    Copy the full SHA
    53331f7 View commit details
    Browse the repository at this point in the history

  4. Cargo fmt

    @ilitteri
    ilitteri committed Nov 6, 2023
    Configuration menu
    Copy the full SHA
    606f03c View commit details
    Browse the repository at this point in the history

  5. Add calldata vector generation for benches

    @ilitteri
    ilitteri committed Nov 6, 2023
    Configuration menu
    Copy the full SHA
    bb7debb View commit details
    Browse the repository at this point in the history

  6. Merge branch 'main' of github.com:lambdaclass/zksync_era_precompiles … 

    …into p256verify_benches
    @ilitteri
    ilitteri committed Nov 6, 2023
    Configuration menu
    Copy the full SHA
    42e06ca View commit details
    Browse the repository at this point in the history

  7. Fix table

    @ilitteri
    ilitteri committed Nov 6, 2023
    Configuration menu
    Copy the full SHA
    cda0c25 View commit details
    Browse the repository at this point in the history

Commits on Nov 7, 2023

  1. Fix clippy

    @ilitteri
    ilitteri committed Nov 7, 2023
    Configuration menu
    Copy the full SHA
    db36740 View commit details
    Browse the repository at this point in the history

  2. Remove precompile

    @ilitteri
    ilitteri committed Nov 7, 2023
    Configuration menu
    Copy the full SHA
    0b134ec View commit details
    Browse the repository at this point in the history

  3. Add report to list

    @ilitteri
    ilitteri committed Nov 7, 2023
    Configuration menu
    Copy the full SHA
    ed29922 View commit details
    Browse the repository at this point in the history

  4. Update compilers paths

    @ilitteri
    ilitteri committed Nov 7, 2023
    Configuration menu
    Copy the full SHA
    052fdf4 View commit details
    Browse the repository at this point in the history

  5. Update Makefile 

    - Add compilers cmd
- Add benches cmd
    @ilitteri
    ilitteri committed Nov 7, 2023
    Configuration menu
    Copy the full SHA
    942d3fd View commit details
    Browse the repository at this point in the history

  6. Update Makefile

    @ilitteri
    ilitteri committed Nov 7, 2023
    Configuration menu
    Copy the full SHA
    971972b View commit details
    Browse the repository at this point in the history

Commits on Nov 8, 2023

  1. Revert "Update compilers paths" 

    This reverts commit 052fdf4.
    @ilitteri
    ilitteri committed Nov 8, 2023
    Configuration menu
    Copy the full SHA
    6b68b89 View commit details
    Browse the repository at this point in the history

  2. Update makefile

    @ilitteri
    ilitteri committed Nov 8, 2023
    Configuration menu
    Copy the full SHA
    e1cbaf1 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' of github.com:lambdaclass/zksync_era_precompiles … 

    …into p256verify_benches
    @ilitteri
    ilitteri committed Nov 8, 2023
    Configuration menu
    Copy the full SHA
    4fe861b View commit details
    Browse the repository at this point in the history