upgrade rust to 1.74.1

.github/workflows/rust-tests.yml

@@ -9,7 +9,7 @@ on:
 
 env:
   CARGO_TERM_COLOR: always
-  RUST_TOOLCHAIN: '1.72.1'
+  RUST_TOOLCHAIN: '1.74.1'
 
 jobs:
   build:

Makefile

@@ -166,7 +166,7 @@ deps: check-python-version build-cairo-2-compiler build-cairo-1-compiler
 	-pyenv && pyenv install -s 3.9.15
 	python3.9 -m venv starknet-venv
 	. starknet-venv/bin/activate && $(MAKE) deps-venv
-	cargo install cargo-nextest --version 0.9.49
+	cargo install cargo-nextest --version 0.9.49 --locked
 
 deps-macos: check-python-version build-cairo-2-compiler-macos build-cairo-1-compiler-macos
 	cargo install flamegraph --version 0.6.2
@@ -175,7 +175,7 @@ deps-macos: check-python-version build-cairo-2-compiler-macos build-cairo-1-comp
 	-pyenv install -s 3.9.15
 	python3.9 -m venv starknet-venv
 	. starknet-venv/bin/activate && $(MAKE) deps-venv
-	cargo install cargo-nextest
+	cargo install cargo-nextest --locked
 
 clean:
 	-rm -rf starknet-venv/

bench/yas.rs

@@ -283,9 +283,6 @@ fn main() -> Result<(), Box<dyn std::error::Error>> {
     let mut state = loop {
         let mut state = state.clone();
 
-        let yas_router_address = yas_router_address;
-        let yas_pool_address = yas_pool_address;
-
         // Swap (invoke).
         info!("Swapping tokens.");
         let t0 = Instant::now();

rust-toolchain.toml

@@ -1,4 +1,4 @@
 [toolchain]
-channel = "1.72.1"
+channel = "1.74.1"
 components = ["rustfmt", "clippy"]
 profile = "minimal"

src/transaction/fee.rs

@@ -221,7 +221,7 @@ pub(crate) fn check_fee_bounds(
         VersionSpecificAccountTxFields::Current(fields) => {
             // Check l1_gas amount
             if (fields.l1_resource_bounds.max_amount as u128) < minimal_l1_gas_amount {
-                return Err(TransactionError::MaxL1GasAmountTooLow(
+                Err(TransactionError::MaxL1GasAmountTooLow(
                     fields.l1_resource_bounds.max_amount,
                     minimal_l1_gas_amount,
                 ))?;
@@ -230,7 +230,7 @@ pub(crate) fn check_fee_bounds(
             let actual_gas_price =
                 block_context.get_gas_price_by_fee_type(&account_tx_fields.fee_type());
             if fields.l1_resource_bounds.max_price_per_unit < actual_gas_price {
-                return Err(TransactionError::MaxL1GasPriceTooLow(
+                Err(TransactionError::MaxL1GasPriceTooLow(
                     fields.l1_resource_bounds.max_price_per_unit,
                     actual_gas_price,
                 ))?;

tests/yas_bench_test.rs

@@ -234,12 +234,6 @@ fn compare_yas_bench() -> Result<(), Box<dyn std::error::Error>> {
     // Execute swaps
 
     for _ in 0..5 {
-        let yas_router_address_jit = yas_router_address_jit;
-        let yas_pool_address_jit = yas_pool_address_jit;
-
-        let yas_router_address_vm = yas_router_address_vm;
-        let yas_pool_address_vm = yas_pool_address_vm;
-
         swap(
             &mut state_jit,
             program_cache_jit.clone(),