Skip to content
This repository has been archived by the owner on Jul 22, 2024. It is now read-only.

upgrade rust to 1.74.1 #1239

Merged
merged 9 commits into from
Feb 19, 2024
Merged

upgrade rust to 1.74.1 #1239

merged 9 commits into from
Feb 19, 2024

Conversation

juanbono
Copy link
Member

@juanbono juanbono commented Feb 14, 2024

Upgrade to Rust 1.74.1

Description

This PR increases the minimum Rust compiler version to 1.74.1.
It also adds the --locked flag to the cargo-nextest dependency

Checklist

  • Linked to Github Issue
  • Unit tests added
  • Integration tests added.
  • This change requires new documentation.
    • Documentation has been added/updated.

@codecov-commenter
Copy link

codecov-commenter commented Feb 14, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (a5597de) 88.96% compared to head (0624b68) 88.98%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1239      +/-   ##
==========================================
+ Coverage   88.96%   88.98%   +0.01%     
==========================================
  Files          52       52              
  Lines       15588    15564      -24     
==========================================
- Hits        13868    13849      -19     
+ Misses       1720     1715       -5     
Files Coverage Δ
src/transaction/fee.rs 91.22% <0.00%> (+0.28%) ⬆️

... and 24 files with indirect coverage changes

@pefontana pefontana added this pull request to the merge queue Feb 15, 2024
@pefontana pefontana removed this pull request from the merge queue due to a manual request Feb 15, 2024
Copy link
Member

@pefontana pefontana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we upgradring the rust version to 1.74?

Copy link
Member

@pefontana pefontana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you update the version in the README.md and in the github/workflows/rust-tests.yml on the coverage line

@pefontana pefontana added this pull request to the merge queue Feb 19, 2024
Merged via the queue into main with commit b7a60e3 Feb 19, 2024
7 checks passed
@pefontana pefontana deleted the upgrade_rust branch February 19, 2024 20:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants