This repository has been archived by the owner on Jul 22, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edg-l
approved these changes
Feb 14, 2024
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1239 +/- ##
==========================================
+ Coverage 88.96% 88.98% +0.01%
==========================================
Files 52 52
Lines 15588 15564 -24
==========================================
- Hits 13868 13849 -19
+ Misses 1720 1715 -5
|
pefontana
approved these changes
Feb 15, 2024
pefontana
suggested changes
Feb 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we upgradring the rust version to 1.74?
azteca1998
approved these changes
Feb 16, 2024
pefontana
suggested changes
Feb 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you update the version in the README.md and in the github/workflows/rust-tests.yml on the coverage line
uses: dtolnay/[email protected] |
pefontana
approved these changes
Feb 16, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade to Rust 1.74.1
Description
This PR increases the minimum Rust compiler version to 1.74.1.
It also adds the
--locked
flag to thecargo-nextest
dependencyChecklist