Implement most signature hints #291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmoletta
changed the title
DIV_MOD_N_SAFE_DIV, DIV_MOD_N_SAFE_DIV_PLUS_ONE & XS_SAFE_DIV hints
pefontana
approved these changes
Sep 29, 2023
mmsc2
reviewed
Sep 29, 2023
| @@ -63,3 +63,42 @@ func SafeDivBig(x *big.Int, y *big.Int) (*big.Int, error) { | |||
| } | |||
| return q, nil | |||
| } | |||
|
|
|||
| // Finds a nonnegative integer x < p such that (m * x) % p == n. | |||
| func DivMod(n *big.Int, m *big.Int, p *big.Int) (*big.Int, error) { | |||
There was a problem hiding this comment.
did not this function already exists in math_utils/utils.go ? why do we have two implementations?
There was a problem hiding this comment.
yes, Ill remove the redundant implementation and merge both packages
mmsc2
approved these changes
Oct 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on: #275
Contains code that was cherry-picked into: #292 #293
Implements all hints in #202 except for
GET_POINT_FROM_XAlso: