Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement REDUCE+ & VERIFY_ZERO+ hints #307

Merged
merged 120 commits into from
Oct 25, 2023
Merged

Implement REDUCE+ & VERIFY_ZERO+ hints #307

merged 120 commits into from
Oct 25, 2023

Conversation

fmoletta
Copy link
Contributor

@fmoletta fmoletta commented Sep 29, 2023

Closes #266
Partially addresses #203
Depends on #291
Contains change from #308

@fmoletta fmoletta changed the base branch from signature-hints-3 to signature-hints-4 October 2, 2023 17:12
@fmoletta fmoletta changed the base branch from signature-hints-4 to signature-hints-3 October 2, 2023 17:21
@fmoletta fmoletta changed the title Implement REDUCE_V1 hint Implement REDUCE+ & VERIFY_ZERO+ hints Oct 2, 2023
@fmoletta fmoletta mentioned this pull request Oct 2, 2023
7 tasks
@fmoletta fmoletta marked this pull request as ready for review October 2, 2023 19:12
Base automatically changed from signature-hints-3 to main October 3, 2023 14:58
@codecov-commenter
Copy link

Codecov Report

Merging #307 (e24ff99) into main (76d65f6) will increase coverage by 0.08%.
The diff coverage is 66.66%.

@@            Coverage Diff             @@
##             main     #307      +/-   ##
==========================================
+ Coverage   56.32%   56.41%   +0.08%     
==========================================
  Files          48       49       +1     
  Lines        6409     6463      +54     
==========================================
+ Hits         3610     3646      +36     
- Misses       2430     2442      +12     
- Partials      369      375       +6     
Files Coverage Δ
pkg/hints/hint_processor.go 88.83% <100.00%> (+0.59%) ⬆️
pkg/hints/secp_hints.go 59.09% <59.09%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

fmoletta and others added 2 commits October 5, 2023 17:30
* Add hint code

* Implement hint

* Add unit test

* Fix test value

* Fix hint logic

* Add unit test

* Add integration test

* fmt

* Fix

* Bump cairo-vm version
@toni-calvin toni-calvin added this pull request to the merge queue Oct 25, 2023
Merged via the queue into main with commit c58f01e Oct 25, 2023
2 checks passed
@toni-calvin toni-calvin deleted the secp-hints branch October 25, 2023 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Assorted Hints (3/4)
6 participants