Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove spotlight article #499

Merged
merged 4 commits into from
Nov 9, 2023
Merged

Remove spotlight article #499

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4174fa5
Remove spotlight article
adamiak Nov 9, 2023
06a04c1
Small refactoring
adamiak Nov 9, 2023
63a2b58
Fix formatting errors
adamiak Nov 9, 2023
ad8d9cd
Update packages/frontend/src/view/pages/home/HomePage.tsx
adamiak Nov 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions packages/frontend/src/view/pages/home/HomePage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@ import {
OFFER_TABLE_PROPS,
STATE_UPDATE_TABLE_PROPS,
} from './common'
import { HomeSpotlightArticle } from './components/HomeSpotlightArticle'
import {
HomeStateUpdateEntry,
HomeStateUpdatesTable,
Expand All @@ -46,7 +45,6 @@ const MAX_TUTORIALS = 3

function HomePage(props: HomePageProps) {
const showViewAllTutorials = props.tutorials.length > 3
const lastTutorial = props.tutorials[MAX_TUTORIALS - 1]

return (
<Page
Expand Down Expand Up @@ -87,12 +85,6 @@ function HomePage(props: HomePageProps) {
className="xl:hidden"
/>
)}
{lastTutorial && (
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets also change MAX_TUTORIALS to 2 then on line 76 remove the "- 1" part and change 48 lane to const showViewAllTutorials = props.tutorials.length > MAX_TUTORIALS

<HomeSpotlightArticle
spotlightArticle={lastTutorial}
className="hidden xl:grid"
/>
)}
</div>
</ContentWrapper>
</Page>
Expand Down