Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove spotlight article #499

Merged
merged 4 commits into from
Nov 9, 2023
Merged

Remove spotlight article #499

merged 4 commits into from
Nov 9, 2023

Conversation

adamiak
Copy link
Member

@adamiak adamiak commented Nov 9, 2023

The size of the spotlight component is too big for the content, and we need to rethink if it even makes sense to show the tutorial there.

@adamiak adamiak requested a review from torztomasz November 9, 2023 10:04
@@ -87,12 +85,6 @@ function HomePage(props: HomePageProps) {
className="xl:hidden"
/>
)}
{lastTutorial && (
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets also change MAX_TUTORIALS to 2 then on line 76 remove the "- 1" part and change 48 lane to const showViewAllTutorials = props.tutorials.length > MAX_TUTORIALS

@adamiak adamiak enabled auto-merge November 9, 2023 10:23
@adamiak adamiak added this pull request to the merge queue Nov 9, 2023
Merged via the queue into master with commit b1ca270 Nov 9, 2023
@adamiak adamiak deleted the remove-spotlight-article branch November 9, 2023 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants