Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Reduce CPU memory usage caused by Istio existence check #1452

Merged

Conversation

jeffreylimnardy
Copy link
Contributor

@jeffreylimnardy jeffreylimnardy commented Sep 17, 2024

Description

Changes proposed in this pull request (what was done and why):

  • Use client-go Discovery API instead of listing all CRDs in the cluster, which may cause CPU throttling issues in clusters with a lot of large CRDs.

Profiling results:

  • Logs
    Before
    pprof_log_old_k3d
    With Discovery API
    pprof_log_new_k3d

  • Metrics
    Before
    pprof_metric_old_k3d
    With Discovery API
    pprof_metric_new_k3d

  • Traces
    Before
    pprof_trace_old_k3d
    With Discovery API
    pprof_trace_new_k3d

  • Discovery API calls take on average 10 ms to complete

Changes refer to particular issues, PRs or documents:

Traceability

  • The PR is linked to a GitHub issue.
  • The follow-up issues (if any) are linked in the Related Issues section.
  • If the change is user-facing, the documentation has been adjusted.
  • The feature is unit-tested.
  • The feature is e2e-tested.

@jeffreylimnardy jeffreylimnardy self-assigned this Sep 17, 2024
@jeffreylimnardy jeffreylimnardy requested a review from a team as a code owner September 17, 2024 11:09
@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 17, 2024
@jeffreylimnardy jeffreylimnardy added kind/bug Categorizes issue or PR as related to a bug. area/manager Manager or module changes cla: yes Indicates the PR's author has signed the CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cla: yes Indicates the PR's author has signed the CLA. labels Sep 17, 2024
@jeffreylimnardy jeffreylimnardy added this to the 1.24.0 milestone Sep 17, 2024
@kyma-bot kyma-bot added the lgtm Looks good to me! label Sep 17, 2024
@skhalash skhalash merged commit 3d537e1 into kyma-project:main Sep 17, 2024
44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/manager Manager or module changes cla: yes Indicates the PR's author has signed the CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm Looks good to me! size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants