Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Cleanup unused crd functions #1467

Merged
merged 2 commits into from
Sep 24, 2024
Merged

chore: Cleanup unused crd functions #1467

merged 2 commits into from
Sep 24, 2024

Conversation

jeffreylimnardy
Copy link
Contributor

Description

Changes proposed in this pull request (what was done and why):

  • Remove CRDs from MetricPipeline watched resources
  • Remove RBAC annotations for CRDs
  • Regenerate RBAC manifests

Changes refer to particular issues, PRs or documents:

Traceability

  • The PR is linked to a GitHub issue.
  • The follow-up issues (if any) are linked in the Related Issues section.
  • If the change is user-facing, the documentation has been adjusted.
  • The feature is unit-tested.
  • The feature is e2e-tested.

@jeffreylimnardy jeffreylimnardy added kind/chore Categorizes issue or PR as related to a chore. area/manager Manager or module changes labels Sep 23, 2024
@jeffreylimnardy jeffreylimnardy self-assigned this Sep 23, 2024
@jeffreylimnardy jeffreylimnardy requested a review from a team as a code owner September 23, 2024 15:04
@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 23, 2024
@kyma-bot kyma-bot added the lgtm Looks good to me! label Sep 23, 2024
@jeffreylimnardy jeffreylimnardy added this to the 1.24.0 milestone Sep 23, 2024
@kyma-bot kyma-bot merged commit 4e4f824 into kyma-project:main Sep 24, 2024
54 of 66 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skhalash skhalash skhalash approved these changes

Assignees

@skhalash skhalash

@jeffreylimnardy jeffreylimnardy

Labels
area/manager Manager or module changes cla: yes Indicates the PR's author has signed the CLA. kind/chore Categorizes issue or PR as related to a chore. lgtm Looks good to me! size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
1.24.0
Development

Successfully merging this pull request may close these issues.
3 participants
@jeffreylimnardy @skhalash @kyma-bot