Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance runtime input with selectors for PVC volumes #1301

Closed
a-thaler opened this issue Jul 25, 2024 · 2 comments
Closed

Enhance runtime input with selectors for PVC volumes #1301

a-thaler opened this issue Jul 25, 2024 · 2 comments
Assignees
Labels
area/metrics MetricPipeline kind/feature Categorizes issue or PR as related to a new feature.
Milestone

Comments

@a-thaler
Copy link
Collaborator

a-thaler commented Jul 25, 2024

Description
As part of #972 enhance the current runtime input with a new selector for volumes. It should be disabled by default.

Criterias

  • A new selector is added to the runtime input which will emit metrics as outlined in Metric API proposal to cover typical Kubernetes metrics #1001 (comment)
  • The selector can be used independent of the other selectors, if this selector is enabled only, only the related metrics are exported
  • The new metrics are based on the existing k8sclusterreicever being wrapped with the leader-election-receiver
  • Multiple pipelines having different selector settings will result in different metrics being exported
  • Assure that only metrics for volumes being attached to a PVC are exported. Other volumes should be filtered out
  • Check with the Cloud Manager team how much these metrics are useful for NFS volumes and decide if they should be included or excluded
  • The k8sclusterreicever is running at the agent instead of gateway as it is representing an optional input
  • There is no runtime instrumentation scope processor in the gateway

Tasks

  • Add new feature with filter for PVC volumes
  • Align with cloud manager about NFC volumes
  • Verify proper instrumentation scope is in use
  • Enhance documentation
  • Enhance E2E test for runtime input (to assure compatibility of the emmitted metrics)

Reasons

Attachments

Release Notes


@a-thaler a-thaler added kind/feature Categorizes issue or PR as related to a new feature. area/metrics MetricPipeline labels Jul 25, 2024
Copy link

This issue has been automatically marked as stale due to the lack of recent activity. It will soon be closed if no further activity occurs.
Thank you for your contributions.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 24, 2024
@a-thaler a-thaler removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 24, 2024
@rakesh-garimella rakesh-garimella self-assigned this Oct 1, 2024
@shorim shorim assigned shorim and unassigned rakesh-garimella Oct 1, 2024
@a-thaler a-thaler added this to the 1.26.0 milestone Oct 8, 2024
@rakesh-garimella
Copy link
Contributor

The changes wrt to volume metrics has been implemented and also the k8sCluster has been moved to metric agent

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/metrics MetricPipeline kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

No branches or pull requests

3 participants