Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add a selector for runtime volume metrics #1486

Merged
merged 38 commits into from
Oct 11, 2024

Conversation

shorim
Copy link
Contributor

@shorim shorim commented Oct 1, 2024

Description

Changes proposed in this pull request (what was done and why):

  • Add a selector in MetricPipeline CRDs for enabling/disabling the collection of volume metrics
  • Refactor the creation of metric_groups list in kubeletstats receiver: a metric group is now only added to the list if at least one MetricPipeline has the corresponding input selector enabled. This will let us avoid sending unnecessary metrics to the gateway which will be dropped by all pipelines.
  • Extract the checks for the enabled inputs to the metrics pkg, so that it can be used in both gateway and agent packages
  • In order to add the k8s.volume.type resource attribute to volume metrics, extra_metadata_labels field is added to the kubeletstats receiver and the permission for the agent to read the nodes/proxy resource is added to the ClusterRole of the agent
  • Add filter/drop-non-pvc-volumes-metrics in agent to filter only for PVC volume metrics and drop metrics from other volumes types
  • Add filter/drop-runtime-volume-metrics in gateway to drop volume metrics for pipelines in which volume metrics are disabled
  • Add unit and e2e tests
  • Adjust busola ConfigMap for MetricPipeline

Changes refer to particular issues, PRs or documents:

Traceability

  • The PR is linked to a GitHub issue.
  • The follow-up issues (if any) are linked in the Related Issues section.
  • If the change is user-facing, the documentation has been adjusted.
  • If a CRD is changed, the corresponding Busola ConfigMap has been adjusted.
  • The feature is unit-tested.
  • The feature is e2e-tested.

@shorim shorim added kind/feature Categorizes issue or PR as related to a new feature. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. area/metrics MetricPipeline labels Oct 1, 2024
@shorim shorim added this to the 1.25.0 milestone Oct 1, 2024
@shorim shorim requested a review from a team as a code owner October 1, 2024 14:07
@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 1, 2024
@shorim shorim requested a review from a team as a code owner October 4, 2024 12:18
@kyma-bot kyma-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 7, 2024
@a-thaler a-thaler modified the milestones: 1.25.0, 1.26.0 Oct 8, 2024
@kyma-bot kyma-bot removed the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 10, 2024
NHingerl
NHingerl previously approved these changes Oct 10, 2024
@kyma-bot kyma-bot added the lgtm Looks good to me! label Oct 10, 2024
@kyma-bot kyma-bot removed the lgtm Looks good to me! label Oct 10, 2024
@kyma-bot kyma-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Oct 10, 2024
@kyma-bot kyma-bot added the lgtm Looks good to me! label Oct 11, 2024
@skhalash skhalash enabled auto-merge (squash) October 11, 2024 12:21
@kyma-bot kyma-bot removed the lgtm Looks good to me! label Oct 11, 2024
@kyma-bot
Copy link
Contributor

New changes are detected. LGTM label has been removed.

@rakesh-garimella rakesh-garimella added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Oct 11, 2024
@skhalash skhalash merged commit 7adb021 into kyma-project:main Oct 11, 2024
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/metrics MetricPipeline cla: yes Indicates the PR's author has signed the CLA. kind/feature Categorizes issue or PR as related to a new feature. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants