generated from kyma-project/template-repository
-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add a selector for runtime volume metrics #1486
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shorim
added
kind/feature
Categorizes issue or PR as related to a new feature.
do-not-merge/hold
Indicates that a PR should not merge because someone has issued a /hold command.
area/metrics
MetricPipeline
labels
Oct 1, 2024
kyma-bot
added
cla: yes
Indicates the PR's author has signed the CLA.
size/M
Denotes a PR that changes 30-99 lines, ignoring generated files.
labels
Oct 1, 2024
kyma-bot
added
size/L
Denotes a PR that changes 100-499 lines, ignoring generated files.
and removed
size/M
Denotes a PR that changes 30-99 lines, ignoring generated files.
labels
Oct 7, 2024
kyma-bot
removed
the
size/L
Denotes a PR that changes 100-499 lines, ignoring generated files.
label
Oct 10, 2024
NHingerl
previously approved these changes
Oct 10, 2024
kyma-bot
added
size/XL
Denotes a PR that changes 500-999 lines, ignoring generated files.
and removed
size/XXL
Denotes a PR that changes 1000+ lines, ignoring generated files.
labels
Oct 10, 2024
k15r
approved these changes
Oct 11, 2024
mmitoraj
approved these changes
Oct 11, 2024
New changes are detected. LGTM label has been removed. |
rakesh-garimella
added
do-not-merge/hold
Indicates that a PR should not merge because someone has issued a /hold command.
and removed
do-not-merge/hold
Indicates that a PR should not merge because someone has issued a /hold command.
labels
Oct 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/metrics
MetricPipeline
cla: yes
Indicates the PR's author has signed the CLA.
kind/feature
Categorizes issue or PR as related to a new feature.
size/XL
Denotes a PR that changes 500-999 lines, ignoring generated files.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes proposed in this pull request (what was done and why):
MetricPipeline
CRDs for enabling/disabling the collection of volume metricsmetric_groups
list inkubeletstats
receiver: a metric group is now only added to the list if at least oneMetricPipeline
has the corresponding input selector enabled. This will let us avoid sending unnecessary metrics to the gateway which will be dropped by all pipelines.metrics
pkg, so that it can be used in bothgateway
andagent
packagesk8s.volume.type
resource attribute to volume metrics,extra_metadata_labels
field is added to thekubeletstats
receiver and the permission for the agent to read thenodes/proxy
resource is added to theClusterRole
of the agentfilter/drop-non-pvc-volumes-metrics
in agent to filter only for PVC volume metrics and drop metrics from other volumes typesfilter/drop-runtime-volume-metrics
in gateway to drop volume metrics for pipelines in which volume metrics are disabledConfigMap
forMetricPipeline
Changes refer to particular issues, PRs or documents:
Traceability
Related Issues
section.