Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Move k8s cluster receiver to agent #1509

Merged
merged 17 commits into from
Oct 15, 2024
Merged

feat: Move k8s cluster receiver to agent #1509

merged 17 commits into from
Oct 15, 2024

Conversation

rakesh-garimella
Copy link
Contributor

@rakesh-garimella rakesh-garimella commented Oct 9, 2024 •
edited
Loading

Description

Changes proposed in this pull request (what was done and why):

  • Move k8sClusterreceiver into metric agent
  • Move the filter processor for filtering unwated metrics from k8sClusterReceiver to agent
  • Move RBAC for k8s cluster receiver to agen
  • Add new role and rolebinding for metric agent
  • Refactored MakeInstrumentationScopeProcessor to support multiple inputSources

Changes refer to particular issues, PRs or documents:

Traceability

  • The PR is linked to a GitHub issue.
  • The follow-up issues (if any) are linked in the Related Issues section.
  • If the change is user-facing, the documentation has been adjusted.
  • If a CRD is changed, the corresponding Busola ConfigMap has been adjusted.
  • The feature is unit-tested.
  • The feature is e2e-tested.

@rakesh-garimella rakesh-garimella requested a review from a team as a code owner October 9, 2024 14:51
@kyma-bot kyma-bot added the cla: yes Indicates the PR's author has signed the CLA. label Oct 9, 2024
@rakesh-garimella rakesh-garimella added kind/feature Categorizes issue or PR as related to a new feature. area/metrics MetricPipeline and removed cla: yes Indicates the PR's author has signed the CLA. labels Oct 9, 2024
@kyma-bot kyma-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 9, 2024
@rakesh-garimella rakesh-garimella added this to the 1.26.0 milestone Oct 9, 2024
@kyma-bot kyma-bot added the cla: yes Indicates the PR's author has signed the CLA. label Oct 9, 2024
@kyma-bot kyma-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 10, 2024
@rakesh-garimella rakesh-garimella added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 11, 2024
@rakesh-garimella rakesh-garimella removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 15, 2024
@kyma-bot kyma-bot added the lgtm Looks good to me! label Oct 15, 2024
@rakesh-garimella rakesh-garimella merged commit b49c390 into kyma-project:main Oct 15, 2024
40 checks passed
@rakesh-garimella rakesh-garimella deleted the move-k8s-cluster-receiver-to-agent branch October 15, 2024 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hisarbalik hisarbalik hisarbalik approved these changes

Assignees

@hisarbalik hisarbalik

Labels
area/metrics MetricPipeline cla: yes Indicates the PR's author has signed the CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm Looks good to me! size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
1.26.0
Development

Successfully merging this pull request may close these issues.
3 participants
@rakesh-garimella @hisarbalik @kyma-bot