Align runtime-watcher image names

[c-pius]

Description

We use different image names for runtime-watcher in Dev and Prod registries:

lifecycle-manager/cmd/main.go

Lines 358 to 361 in 2ad71dd

	const (
	watcherRegProd = "europe-docker.pkg.dev/kyma-project/prod/runtime-watcher-skr"
	watcherRegDev = "europe-docker.pkg.dev/kyma-project/dev/runtime-watcher"
	)

Recently, when adapting build pipelines, we confused things up already. We should align the name and use the same for both registries.

Reasons

Consistency and less prone to mistakes

Acceptance Criteria

• agreed on a common name => runtime-watcher (NO -skr suffix)
• updated pipelines to build the image using the common name
• updated code to use the image using the common name
• verify that it works e2e without -skr suffix
• EDIT CS: consider to update management plane charts to provide the registry value explicitly (as of now it would take the default)

Feature Testing

No response

Testing approach

No response

Attachments

No response

[c-pius]

Prio to be discussed. We may need to have it fixed before the next watcher release.

[c-pius]

updated pipelines to build the image using the common name

watcher is now uniformely built with runtime-watcher name: https://github.com/kyma-project/runtime-watcher/blob/main/.github/workflows/build-image.yml#L41

updated code to use the image using the common name

implementation at KLM side is: #1868

See the comments wrt. to the issues with e2e tests

verify that it works e2e without -skr suffix

runtime watcher also needs to be updated to pass the new patch. PR for this is here: kyma-project/runtime-watcher#385