Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Align runtime-watcher registry and make configurable #1868

Merged
merged 16 commits into from
Sep 23, 2024
Merged

chore: Align runtime-watcher registry and make configurable #1868

merged 16 commits into from
Sep 23, 2024

Conversation

c-pius
Copy link
Contributor

@c-pius c-pius commented Sep 12, 2024

Description

Changes proposed in this pull request:

  • removes the code handling of different runtime-watcher registries and image names and provides those as flags instead
    • image-name has a default
    • image-registry must be provided as flag
  • adds unit tests for the flagVar.Validate()

Related issue(s)

@c-pius c-pius requested a review from a team as a code owner September 12, 2024 14:48
@kyma-bot kyma-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cla: yes Indicates the PR's author has signed the CLA. labels Sep 12, 2024
This was referenced Sep 13, 2024
Closed
Closed
@c-pius c-pius changed the base branch from main to chore/align-skr-watcher-image-registry September 23, 2024 13:33
@c-pius c-pius merged commit e4f22be into kyma-project:chore/align-skr-watcher-image-registry Sep 23, 2024
59 of 62 checks passed
@c-pius c-pius mentioned this pull request Sep 23, 2024
Merged
c-pius added a commit that referenced this pull request Sep 23, 2024
@c-pius
chore: Align runtime-watcher registry and make configurable (#1868) (#…
7d205cb 
…1884)

* chore: Align runtime-watcher registry and make configurable

* bump watcher version

* fix linting

* test flag defaults

* remove efault for watcher image

* describe and logs

* quote value

* test echo; no wait for build-iamge

* test echo

* PR instead of PR_target

* revert test stuff; add flag default

* default watcher image

* remove quotes

* revert faulty image name
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla: yes Indicates the PR's author has signed the CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Align runtime-watcher image names
2 participants
@c-pius @kyma-bot