chore: Align runtime-watcher registry and make configurable (#1868) #1884
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* chore: Align runtime-watcher registry and make configurable * bump watcher version * fix linting * test flag defaults * remove efault for watcher image * describe and logs * quote value * test echo; no wait for build-iamge * test echo * PR instead of PR_target * revert test stuff; add flag default * default watcher image * remove quotes * revert faulty image name
kyma-bot
added
cla: yes
c-pius
commented
Sep 23, 2024
Comment on lines
-328
to
+339
| if f.ManifestRequeueJitterProbability < 0 || f.ManifestRequeueJitterProbability > 1 { | ||
| return errInvalidManifestRequeueJitterProbability | ||
| if f.ManifestRequeueJitterPercentage < 0 || f.ManifestRequeueJitterPercentage > 1 { | ||
| return ErrInvalidManifestRequeueJitterProbability |
There was a problem hiding this comment.
to reviewer: this seems to be a bug from the previous implementation. There were two checks for probability and no one for percentage
ghost
approved these changes
Sep 23, 2024
ruanxin
approved these changes
Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original PR #1868 was merged to a feature branch so that we can run the E2E tests without the
pull_request_targetrelated issues.A test PR for running the E2E tests is here: #1883
Related Issues