Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Malformatted EventMesh Secret causes warning status #520

Merged
merged 9 commits into from
Mar 7, 2024
Merged

fix: Malformatted EventMesh Secret causes warning status #520

merged 9 commits into from
Mar 7, 2024

Conversation

friedrichwilken
Copy link
Contributor

@friedrichwilken friedrichwilken commented Mar 6, 2024 •
edited
Loading

Description

Changes proposed in this pull request:

  • A malformatted EventMesh Secret no longer causes the error status but the warning status.
  • Changes the linter to the common linter.

Related issue(s)
#490

@friedrichwilken friedrichwilken requested a review from a team as a code owner March 6, 2024 17:00
@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 6, 2024
@kyma-bot kyma-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 6, 2024
@friedrichwilken friedrichwilken force-pushed the bad-em-secret-causes-warning branch 6 times, most recently from b4e1d5d to f478756 Compare March 6, 2024 22:12
@kyma-bot kyma-bot added the area/ci Issues or PRs related to CI related topics label Mar 7, 2024
@friedrichwilken friedrichwilken changed the title Bad em secret causes warning Malformatted EventMesh Secret causes warning status Mar 7, 2024
@friedrichwilken friedrichwilken changed the title Malformatted EventMesh Secret causes warning status fix: Malformatted EventMesh Secret causes warning status Mar 7, 2024
@friedrichwilken friedrichwilken linked an issue Mar 7, 2024 that may be closed by this pull request
Set warning to Eventing CR state if EventMesh secret is malformatted #490
Closed
@kyma-bot kyma-bot added the lgtm Looks good to me! label Mar 7, 2024
@kyma-bot kyma-bot merged commit 7215347 into kyma-project:main Mar 7, 2024
14 checks passed
@friedrichwilken friedrichwilken deleted the bad-em-secret-causes-warning branch March 7, 2024 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mfaizanse mfaizanse mfaizanse approved these changes

@the1bit the1bit Awaiting requested review from the1bit

Assignees

@mfaizanse mfaizanse

Labels
area/ci Issues or PRs related to CI related topics cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Set warning to Eventing CR state if EventMesh secret is malformatted
3 participants
@friedrichwilken @mfaizanse @kyma-bot